feat: onboard klaviyo bulk upload destination #4682

yashasvibajpai · 2024-05-15T21:13:49Z

Description

Onboarding a new batch router bulk upload destination Klaviyo Bulk Upload

Linear Ticket

https://linear.app/rudderstack/issue/INT-1957/klaviyo-implement-bulk-upload-api

Security

The code changed/added as part of this pull request won't create any security issues with how the software is being used.

coderabbitai · 2024-05-15T21:13:55Z

Important

Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Tip

Early Access Features

gpt-4o model for chat

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2024-05-25T22:16:06Z

Codecov Report

Attention: Patch coverage is 2.76680% with 246 lines in your changes are missing coverage. Please review.

Project coverage is 74.34%. Comparing base (51e3e4e) to head (94f90ff).
Report is 3 commits behind head on master.

❗ Current head 94f90ff differs from pull request most recent head cb51eb0

Please upload reports for the commit cb51eb0 to get more accurate results.

Files	Patch %	Lines
...tionmanager/klaviyobulkupload/klaviyobulkupload.go	2.40%	244 Missing ⚠️
...ter/batchrouter/asyncdestinationmanager/manager.go	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4682      +/-   ##
==========================================
- Coverage   74.60%   74.34%   -0.27%     
==========================================
  Files         414      415       +1     
  Lines       48546    48798     +252     
==========================================
+ Hits        36220    36280      +60     
- Misses       9954    10152     +198     
+ Partials     2372     2366       -6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

router/batchrouter/asyncdestinationmanager/klaviyobulkupload/klaviyobulkupload.go

koladilip · 2024-05-27T06:10:57Z

router/batchrouter/asyncdestinationmanager/klaviyobulkupload/klaviyobulkupload.go

+ }
+}
+
+func (kbu *KlaviyoBulkUploader) ExtractProfiles(input map[string]interface{}) ([]map[string]interface{}, error) {


define struct for input type

router/batchrouter/asyncdestinationmanager/klaviyobulkupload/klaviyobulkupload.go

koladilip · 2024-05-29T05:03:28Z

router/batchrouter/asyncdestinationmanager/klaviyobulkupload/klaviyobulkupload.go

+ Json := Body.JSON
+ Data := Json.Data
+ Attributes := Data.Attributes
+ profileObject := Attributes.Profiles.Data[0]


have check for length of Attributes.Profiles.Data so that you can avoid nil pointer

koladilip · 2024-05-29T05:03:42Z

router/batchrouter/asyncdestinationmanager/klaviyobulkupload/klaviyobulkupload.go

- message, ok := input["message"].(map[string]interface{})
- if !ok {
- return nil, fmt.Errorf("message field not found or not a map")
+func (kbu *KlaviyoBulkUploader) ExtractProfile(input Input) (Profile, error) {


add test cases for this

koladilip · 2024-05-29T05:04:38Z

router/batchrouter/asyncdestinationmanager/klaviyobulkupload/types.go

+ Attributes struct {
+ Profiles struct {
+ Data []struct {
+ Attributes struct {


can we reuse: type ProfilesAttributes struct {

Have removed this type itself as It was redundant and causing errors

koladilip · 2024-05-29T05:05:22Z

router/batchrouter/asyncdestinationmanager/klaviyobulkupload/types.go

+ } `json:"metadata,omitempty"`
+}
+
+type Profile struct {


this needs bit of clean up, there duplicates

router/batchrouter/asyncdestinationmanager/common/common.go

router/batchrouter/asyncdestinationmanager/klaviyobulkupload/klaviyobulkupload.go

feat: onboard klaviyo bulk upload destination, initial commitx2

02bf068

yashasvibajpai requested a review from ItsSudip May 15, 2024 21:13

yashasvibajpai self-assigned this May 15, 2024

chore: refactor logic, add polling logic

89f94ba

yashasvibajpai requested a review from sanpj2292 May 21, 2024 21:55

yashasvibajpai changed the title ~~feat: onboard klaviyo bulk upload destination, initial commitx2~~ feat: onboard klaviyo bulk upload destination May 21, 2024

yashasvibajpai added 3 commits May 22, 2024 19:03

chore: update poll logic

de96856

chore: update errorStatus logic

5e75c0b

chore: refactor errorStatus logic

fb889c0

yashasvibajpai added WIP work in progress Do not merge labels May 24, 2024

yashasvibajpai marked this pull request as ready for review May 24, 2024 19:36

yashasvibajpai added 3 commits May 25, 2024 01:11

Merge branch 'master' into feat.klaviyo.bulk.upload

50d4f60

chore: lint fixes for build

b36167e

chore: lint fixes for build, fix missed transform

be6da91

yashasvibajpai added 3 commits May 27, 2024 04:57

chore: add test and related mocks

99f5212

chore: fix linting

939d6cc

chore: fix lintingx2

afb0b54

yashasvibajpai removed Do not merge WIP work in progress labels May 27, 2024

koladilip reviewed May 27, 2024

View reviewed changes

yashasvibajpai added 6 commits May 28, 2024 01:20

chore: add destname to utils

1987578

chore: refactor, address comment

ad152fc

chore: refactor, move type declarations

0b6801e

Merge branch 'master' into feat.klaviyo.bulk.upload

0b7d2d7

chore: address review comments

78d484a

chore: lint fixes

db7151c

koladilip reviewed May 29, 2024

View reviewed changes

chore: remove unused type

94f90ff

ItsSudip approved these changes May 29, 2024

View reviewed changes

chore: address review comments2

cb51eb0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: onboard klaviyo bulk upload destination #4682

feat: onboard klaviyo bulk upload destination #4682

yashasvibajpai commented May 15, 2024 •

edited

coderabbitai bot commented May 15, 2024 •

edited

Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

codecov bot commented May 25, 2024 •

edited

koladilip May 27, 2024

koladilip May 29, 2024 •

edited

koladilip May 29, 2024

koladilip May 29, 2024

yashasvibajpai May 29, 2024

koladilip May 29, 2024

feat: onboard klaviyo bulk upload destination #4682

Are you sure you want to change the base?

feat: onboard klaviyo bulk upload destination #4682

Conversation

yashasvibajpai commented May 15, 2024 • edited

Description

Linear Ticket

Security

coderabbitai bot commented May 15, 2024 • edited

Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

codecov bot commented May 25, 2024 • edited

Codecov Report

koladilip May 27, 2024

Choose a reason for hiding this comment

koladilip May 29, 2024 • edited

Choose a reason for hiding this comment

koladilip May 29, 2024

Choose a reason for hiding this comment

koladilip May 29, 2024

Choose a reason for hiding this comment

yashasvibajpai May 29, 2024

Choose a reason for hiding this comment

koladilip May 29, 2024

Choose a reason for hiding this comment

yashasvibajpai commented May 15, 2024 •

edited

coderabbitai bot commented May 15, 2024 •

edited

CodeRabbit Configration File (`.coderabbit.yaml`)

codecov bot commented May 25, 2024 •

edited

koladilip May 29, 2024 •

edited