[Bug #20468] More strictly check loop variable #10723
Open
+111
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prohibit a constant and safe navigation call as a loop variable of `for`.
eregon
reviewed
May 4, 2024
| }.should complain(/already initialized constant/) | ||
| CONST.should == 3 | ||
| n.should == 3 | ||
| ruby_bug("#20468", ""..."3.4") do |
There was a problem hiding this comment.
Do you think this PR will be backported?
I would think not as-is since it could emit SyntaxError where it previously worked OK (although weird code).
If not backported, I think we should keep the old spec under ruby_version_is ""..."3.4" do and add the new spec under ruby_version_is "3.4" do
There was a problem hiding this comment.
I'm uncertain yet whether this would be desirable and it should be backported.
I'll ask matz on the next Tuesday.
IMO, the current behavior is not expected and not a specification, so ""..."3.4" part does is unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prohibit a constant and safe navigation call as a loop variable of
for.