Fix macos bug deleting too many files #10699
Open
+2
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #10209 we've been noticing that on macos after running
make clean
thecoroutine/arm64/Context.S
file is missing, causing subsequent make calls to fail becauseContext.S
is needed to buildContext.o
.The reason this is happening is because macos is case-insensitive so the
.s
looks forcoroutine/arm64/Context.s
and findscoroutine/arm64/Context.S
and deletes it. This does not happen on linux because the filesystem is case sensitive.I attempted to use
find
because it is case sensitive regardless of filesystem, but it was a lot slower thanrm
since we can't pass multiple file names the same way tofind
.Reverting this small part of #10209 fixes the issue for macos and it wasn't clear that those changes were strictly necessary for the rest of the PR.
cc/ @nobu as the author of #10209