[Fix #11585] Support AllowedMethods for Style/DocumentationMethod
#12893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbatsov
reviewed
May 16, 2024
| @@ -993,6 +993,19 @@ def foo.baz | |||
| end | |||
| end | |||
| end | |||
|
|
|||
| describe 'when AllowedConstants is configured' do | |||
There was a problem hiding this comment.
AllowedConstants -> AllowedMethods
bbatsov
reviewed
May 16, 2024
| describe 'when AllowedConstants is configured' do | ||
| before { config['Style/DocumentationMethod'] = { 'AllowedMethods' => ['method_missing'] } } | ||
|
|
||
| it 'ignores the constants in the config' do |
|
@koic ping :-) |
…Method` Fixes rubocop#11585. This PR supports `AllowedMethods` for `Style/DocumentationMethod`.
koic
force-pushed
the
support_allowed_methods_for_style_documentation_method
branch
from
bb7b513
to
1de0739
Compare
|
@bbatsov I've updated this PR. Thank you for your review! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11585.
This PR supports
AllowedMethodsforStyle/DocumentationMethod.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.