Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brush fixes and enhancements #3683

Open
wants to merge 44 commits into
base: main
Choose a base branch
from
Open

Brush fixes and enhancements #3683

wants to merge 44 commits into from

Commits on May 12, 2020

  1. Merge pull request #1 from rstudio/master 

    Sync with the origin
    @mjakubczak
    mjakubczak committed May 12, 2020
    Configuration menu
    Copy the full SHA
    5991ed3 View commit details
    Browse the repository at this point in the history

  2. Set plot brush programmatically

    @mjakubczak
    mjakubczak committed May 12, 2020
    Configuration menu
    Copy the full SHA
    ec6e09e View commit details
    Browse the repository at this point in the history

  3. JS and Roxygen build changes

    @mjakubczak
    mjakubczak committed May 12, 2020
    Configuration menu
    Copy the full SHA
    d2fe826 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2022

  1. Merge branch 'mjak' into dev 

    Discard all JS changes; take only R-side functions (mainly to maintain signatures)
    @dvg-p4
    dvg-p4 committed Jun 7, 2022
    Configuration menu
    Copy the full SHA
    bcd9470 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2022

  1. specify where submodule is supposed to point

    @dvg-p4
    dvg-p4 committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    4f6232b View commit details
    Browse the repository at this point in the history

  2. Bring updateDiv() calls inside of boundsCss()

    @dvg-p4
    dvg-p4 committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    6872fe7 View commit details
    Browse the repository at this point in the history

  3. Works if brush_id is unique

    @dvg-p4
    dvg-p4 committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    c507125 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2022

  1. Make better changes to createBrush

    @dvg-p4
    dvg-p4 committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    da03d0d View commit details
    Browse the repository at this point in the history

  2. Handle invalid panelIdx inputs

    @dvg-p4
    dvg-p4 committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    5f88950 View commit details
    Browse the repository at this point in the history

  3. Remove spurious 'resize' handlers

    @dvg-p4
    dvg-p4 committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    7021f9a View commit details
    Browse the repository at this point in the history

  4. Created user-friendly wrapper functions updateBrushCoords() and reset… 

    …Brush()
    @dvg-p4
    dvg-p4 committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    e15eb02 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2022

  1. Move rounding to just before data send to fix 

    double-renders once and for all
    @dvg-p4
    dvg-p4 committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    c39cdeb View commit details
    Browse the repository at this point in the history

  2. Remove console.log's

    @dvg-p4
    dvg-p4 committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    b46478c View commit details
    Browse the repository at this point in the history

  3. Stop clipping things that ask not to be clipped

    @dvg-p4
    dvg-p4 committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    f2e8352 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2022

  1. "Prevented spurious inputs from date inputs"

    @dvg-p4
    dvg-p4 committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    f0ccc22 View commit details
    Browse the repository at this point in the history

  2. Bump alpha sub-version number

    @dvg-p4
    dvg-p4 committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    4e5ae89 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2022

  1. Fix linked documentation

    @dvg-p4
    dvg-p4 committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    cebc678 View commit details
    Browse the repository at this point in the history

  2. Fully commit to nonstandard version number 

    I just realized there's actually a system for the alpha version numbers, but I want to be able to easily distinguish my fork from the main branch for the time being.
    @dvg-p4
    dvg-p4 committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    285670e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into dev

    @dvg-p4
    dvg-p4 committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    0e9a2d5 View commit details
    Browse the repository at this point in the history

  4. propogate nonstandard version number

    @dvg-p4
    dvg-p4 committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    41675aa View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2022

  1. Round based on range to avoid spurious values near zero

    @dvg-p4
    dvg-p4 committed Jun 20, 2022
    Configuration menu
    Copy the full SHA
    5218a5e View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2022

  1. Bump version number

    @dvg-p4
    dvg-p4 committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    ab4d283 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2022

  1. Merge branch 'fix-throttle' into dev

    @dvg-p4
    dvg-p4 committed Jul 1, 2022
    Configuration menu
    Copy the full SHA
    3d4f166 View commit details
    Browse the repository at this point in the history

  2. made brush/click/hpver handlers persist

    @dvg-p4
    dvg-p4 committed Jul 1, 2022
    Configuration menu
    Copy the full SHA
    9032335 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2022

  1. Merge final throttle fixes from 'main' into 'dev'

    @dvg-p4
    dvg-p4 committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    2ebc4cc View commit details
    Browse the repository at this point in the history

  2. Fixed errors when brush reset mid-drag

    @dvg-p4
    dvg-p4 committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    5a508d2 View commit details
    Browse the repository at this point in the history

  3. Network debugging

    @dvg-p4
    dvg-p4 committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    a74bd17 View commit details
    Browse the repository at this point in the history

  4. only remove handlers when necessary

    @dvg-p4
    dvg-p4 committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    e3f5a46 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2022

  1. Resize brush with cached plots and recover from rendering errors

    @dvg-p4
    dvg-p4 committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    9269967 View commit details
    Browse the repository at this point in the history

  2. Removed console.log's and bump version no.

    @dvg-p4
    dvg-p4 committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    bcf565c View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2022

  1. Remove changes to dates 

    These have their own pull request now
    @dvg-p4
    dvg-p4 committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    0d8a5da View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2022

  1. Merge branch 'main' into brush-fixes-and-enhancements

    @dvg-p4
    dvg-p4 committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    a437664 View commit details
    Browse the repository at this point in the history

  2. Updated pkgdown.yml with new functions

    @dvg-p4
    dvg-p4 committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    90326f7 View commit details
    Browse the repository at this point in the history

  3. Sync package version (GitHub Actions)

    @dvg-p4
    dvg-p4 committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    85707d1 View commit details
    Browse the repository at this point in the history

  4. Started editing NEWS.md; I need to look through the issue backlog to … 

    …remember what all the brush issues were that I was trying to fix
    @dvg-p4
    dvg-p4 committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    98c3128 View commit details
    Browse the repository at this point in the history

  5. Send *debounced* brush coordinates when image resizes

    @dvg-p4
    dvg-p4 committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    b82ec8d View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2022

  1. Cleaned up comments

    @dvg-p4
    dvg-p4 committed Aug 13, 2022
    Configuration menu
    Copy the full SHA
    ec1561c View commit details
    Browse the repository at this point in the history

  2. typo fix

    @dvg-p4
    dvg-p4 committed Aug 13, 2022
    Configuration menu
    Copy the full SHA
    b5cdbae View commit details
    Browse the repository at this point in the history

  3. Fixed comment

    @dvg-p4
    dvg-p4 committed Aug 13, 2022
    Configuration menu
    Copy the full SHA
    ea7845c View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2022

  1. Merge branch 'main' into brush-fixes-and-enhancements

    @dvg-p4
    dvg-p4 committed Sep 9, 2022
    Configuration menu
    Copy the full SHA
    8b97aed View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2023

  1. Bugfix: don't set brush to null while resolving updateBrushCoords

    @dvg-p4
    dvg-p4 committed Feb 20, 2023
    Configuration menu
    Copy the full SHA
    23edc46 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2023

  1. Merge branch 'main' 

    Conflicts:
	NEWS.md
	inst/www/shared/shiny-autoreload.js
	inst/www/shared/shiny-showcase.css
	inst/www/shared/shiny-showcase.js
	inst/www/shared/shiny-testmode.js
	inst/www/shared/shiny.js
	inst/www/shared/shiny.js.map
	inst/www/shared/shiny.min.css
	inst/www/shared/shiny.min.js
	inst/www/shared/shiny.min.js.map
	srcts/src/imageutils/createBrush.ts
	srcts/src/imageutils/createHandlers.ts
	srcts/types/src/imageutils/createHandlers.d.ts
	srcts/types/src/utils/index.d.ts
    @dvg-p4
    dvg-p4 committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    b1a8c75 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' 

    Conflicts:
	inst/www/shared/shiny.js
	inst/www/shared/shiny.js.map
	inst/www/shared/shiny.min.js
	inst/www/shared/shiny.min.js.map
	srcts/src/imageutils/createBrush.ts
	srcts/types/src/imageutils/createBrush.d.ts
	yarn.lock
    @dvg-p4
    dvg-p4 committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    c74959b View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2023

  1. Merge branch 'main' into brush-fixes-and-enhancements

    @dvg-p4
    dvg-p4 committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    919a175 View commit details
    Browse the repository at this point in the history