Mounted router fall back to parent router when route is not found #883
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A different solution to #881
Situation:
/
;/b/z
is mounted at/a
/c
is mounted at/a/b
Goal: Request
/a/b/c
Current behavior:
/a/b/c
matches against mount location of/
./a/b/c
.New behavior:
/a/b/c
matches against mount location of/
./a/b/c
$route()
is marked asrouteNotFound()
/a/b/c
matches against mount location/a
/b/c
/b/c
does not match any routes$route()
is marked asrouteNotFound()
/a/b/c
matches against mount location/a/b
/c
/c
matches route location/c
/c
is returnedThis would allow for #882 to not be merged, keep the docs as the last mount location. This benefits the user in that their content will always have preference over anything mounted in
/__docs__/
PR task list:
$set_fallback(fallback = TRUE)
?$mount(path, router, fallback = TRUE)
?devtools::document()