Add missing retiring federation response code. Use it and existing pe…

…nding federation response code not being used in FederationSupportImpl
rsksmart · Jun 14, 2024 · 5fe05d3 · 5fe05d3
1 parent c550869
commit 5fe05d3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/rskj-core/src/main/java/co/rsk/peg/federation/FederationChangeResponseCode.java b/rskj-core/src/main/java/co/rsk/peg/federation/FederationChangeResponseCode.java
@@ -6,6 +6,7 @@ public enum FederationChangeResponseCode {
  EXISTING_FEDERATION_AWAITING_ACTIVATION(-2),
  EXISTING_RETIRING_FEDERATION(-3),
  PENDING_FEDERATION_NON_EXISTENT(-1),
+ RETIRING_FEDERATION_NON_EXISTENT(-1),
  FEDERATOR_ALREADY_PRESENT(-2),
  INSUFFICIENT_MEMBERS(-2),
  PENDING_FEDERATION_MISMATCHED_HASH(-3),

diff --git a/rskj-core/src/main/java/co/rsk/peg/federation/FederationSupportImpl.java b/rskj-core/src/main/java/co/rsk/peg/federation/FederationSupportImpl.java
@@ -240,7 +240,7 @@ public Address getRetiringFederationAddress() {
  public int getRetiringFederationSize() {
  Federation retiringFederation = getRetiringFederation();
  if (retiringFederation == null) {
- return -1;
+ return FederationChangeResponseCode.RETIRING_FEDERATION_NON_EXISTENT.getCode();
  }
 
  return retiringFederation.getSize();
@@ -250,7 +250,7 @@ public int getRetiringFederationSize() {
  public int getRetiringFederationThreshold() {
  Federation retiringFederation = getRetiringFederation();
  if (retiringFederation == null) {
- return -1;
+ return FederationChangeResponseCode.RETIRING_FEDERATION_NON_EXISTENT.getCode();
  }
 
  return retiringFederation.getNumberOfSignaturesRequired();
@@ -339,7 +339,7 @@ public int getPendingFederationSize() {
  PendingFederation currentPendingFederation = getPendingFederation();
 
  if (currentPendingFederation == null) {
- return -1;
+ return FederationChangeResponseCode.PENDING_FEDERATION_NON_EXISTENT.getCode();
  }
 
  return currentPendingFederation.getSize();