Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): replaces circleci w/ github workflow #275

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jurajpiar
Copy link
Member

@jurajpiar jurajpiar commented Jun 17, 2024

Solves CORE-5765 by removing the CircleCI configuration and migrating it to GHA workflow one.
The sonarqube required some additions to the build.gradle file.

Important

Just before merging this PR we should remove the CircleCI integration in the repo settings @rsksmart/security.

@jurajpiar jurajpiar requested a review from a team June 17, 2024 22:25
@jurajpiar jurajpiar force-pushed the juraj/circleci_to_github_workflow branch 29 times, most recently from 49a9744 to cee3762 Compare June 20, 2024 10:41
@jurajpiar jurajpiar force-pushed the juraj/circleci_to_github_workflow branch 8 times, most recently from 7ff20fd to 07cadfe Compare June 21, 2024 13:51
@jurajpiar jurajpiar marked this pull request as ready for review June 21, 2024 13:52
@jurajpiar jurajpiar requested a review from a team as a code owner June 21, 2024 13:52
@rmoreliovlabs
Copy link
Contributor

LGTM!

rmoreliovlabs
rmoreliovlabs previously approved these changes Jun 24, 2024
@jurajpiar jurajpiar force-pushed the juraj/circleci_to_github_workflow branch from 615408b to fe60d26 Compare June 26, 2024 08:16
Copy link

sonarcloud bot commented Jun 26, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants