Fixed junk output in windows console. (#29) #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For windows runtime, added originalMode or ENABLE_VIRTUAL_TERMINAL_PROCESSING in SetConsoleMode, and if case of any error, disabled color print.
rs
requested changes
Aug 8, 2021
main.go
Outdated
| stdout = &formatter.JSON{ | ||
| Out: stdout, | ||
| Scheme: formatter.DefaultColorScheme, | ||
| // if disbleColor is true, then don't set Scheme. |
There was a problem hiding this comment.
Would be better to declare a scheme variable instead of disableColor + duplication code.
There was a problem hiding this comment.
Sorry my bad. Updated it.
main.go
Outdated
| Out: stderr, | ||
| Scheme: formatter.DefaultColorScheme, | ||
| // if disbleColor is true, then don't set Scheme. | ||
| if disableColor { |
ResetColor issue when color is disabled.
|
After disabling the color in windows in case of error, still I was getting one ResetColor code as junk.
So I updated // If cs is zero that means color is disabled, so only append '\n'
// else append '\n' and ResetColor.
if cs.IsZero() {
cp = append(cp, '\n')
} else {
cp = append(append(cp, '\n'), cs.Color(ResetColor)...)
}Then it worked fine. I hope that was the right way. Let me know if it is not right. Color output in cmd prompt in case of no errors.
|
rs
approved these changes
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue #29
For windows runtime, added
originalModeorENABLE_VIRTUAL_TERMINAL_PROCESSINGinSetConsoleMode, and if case of any error, disabled color print.