Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the useOnListenableChange hook #390

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

gruvw
Copy link

@gruvw gruvw commented Oct 23, 2023

Fixes #389

@rrousselGit
Copy link
Owner

Could you add tests for this?

@gruvw
Copy link
Author

gruvw commented Oct 23, 2023

tell me if the class syntax is correct, I am not sure.

After reviewing the existing test cases briefly, it is evident that I lack the necessary skills to create these tests. Therefore, I am handing over the responsibility of writing tests for this hook to someone who is willing and capable.

@rrousselGit
Copy link
Owner

I'm sure you'd be able to write those tests :)

You could copy-paste the useOnStreamChange as a very good starting point. It's pretty much the same thing we want here

@gruvw
Copy link
Author

gruvw commented Oct 23, 2023

Ok, thank you for the comments, I did the necessary updates. Tell me if the code is good now or if there are other issues.

I might tackle the testing if you think it is within my reach, but certainly not this week.
However, there are a lot of different things I am not familiar with in test/use_on_stream_change_test.dart.

@rrousselGit
Copy link
Owner

Don't worry too much. Try what you can and I can guide you.
View this as a learning opportunity :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: useListener hook
2 participants