Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use sha1_checked for all Sha1 hashing, except for MDC #353

Merged
merged 1 commit into from
May 16, 2024
Merged

use sha1_checked for all Sha1 hashing, except for MDC #353

merged 1 commit into from
May 16, 2024

Conversation

hko-s
Copy link
Contributor

@hko-s hko-s commented May 13, 2024

No description provided.

@hko-s hko-s marked this pull request as draft May 13, 2024 20:34
@hko-s hko-s mentioned this pull request May 13, 2024
Closed
@hko-s hko-s force-pushed the sha1checked branch 5 times, most recently from 673c568 to 5782889 Compare May 13, 2024 20:58
@hko-s hko-s marked this pull request as ready for review May 13, 2024 23:03
dignifiedquire
dignifiedquire reviewed May 14, 2024
View reviewed changes
src/crypto/dsa.rs Outdated Show resolved Hide resolved
dignifiedquire
dignifiedquire reviewed May 14, 2024
View reviewed changes
src/crypto/sym.rs Outdated Show resolved Hide resolved
@hko-s hko-s force-pushed the sha1checked branch 6 times, most recently from acd6cfc to 4b894e1 Compare May 16, 2024 08:47
dignifiedquire
dignifiedquire reviewed May 16, 2024
View reviewed changes
src/errors.rs Outdated Show resolved Hide resolved
dignifiedquire
dignifiedquire reviewed May 16, 2024
View reviewed changes
Copy link
Member

@dignifiedquire dignifiedquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, some nitpicks

dignifiedquire
dignifiedquire approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@dignifiedquire dignifiedquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot

@dignifiedquire dignifiedquire merged commit 7c5e6ae into rpgp:master May 16, 2024
18 checks passed
@hko-s
Copy link
Contributor Author

hko-s commented May 16, 2024

thanks a lot

yay. thank you! :)

@hko-s hko-s deleted the sha1checked branch May 16, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dignifiedquire dignifiedquire dignifiedquire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hko-s @dignifiedquire