Add NIST P curve support to ECDH

[hko-s]

No description provided.

[dignifiedquire]

would be nice to add benchmarks and tests for these new formats, following the existing ones

[hko-s]

would be nice to add benchmarks and tests for these new formats, following the existing ones

I extended the benchmarks, which seemed straightforward.

Regarding tests i am unsure what to extend. I did already add nist curve tests to

rpgp/src/crypto/ecdh.rs

Lines 543 to 548 in 3b91018

	for curve in [
	ECCCurve::Curve25519,
	ECCCurve::P256,
	ECCCurve::P384,
	ECCCurve::P521,
	] {

It looks like the corpus in tests doesn't have any nist artifacts.
Did you have specific ideas what kinds of tests should be added?

[dignifiedquire]

overall looking great, will take some time in the next day to go over the actual crypto algorithms once more

[dignifiedquire]

@hko-s want to move it out of draft, or is there sth else you want to do?

[hko-s]

@hko-s want to move it out of draft, or is there sth else you want to do?

i thought it'd be nice to shape it into two commits:

one that just transforms the previous code, and one that implements nistp.
i just pushed this changed git shape (with unchanged code).

[dignifiedquire]

thanks :)