Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add decoder and balances for Blur protocol #7886

Merged
merged 1 commit into from
May 23, 2024

Conversation

moxw
Copy link
Contributor

@moxw moxw commented May 5, 2024

Handling of Blur staking contracts and associated decoding logic.

sqldiff rotkehlchen/data/develop.db rotkehlchen/data/global.db

INSERT INTO contract_abi(id,value,name) VALUES(90,'[{"inputs":[{"internalType":"address","name":"user","type":"address"}],"name":"balanceOf","outputs":[{"internalType":"uint256","name":"","type":"uint256"}],"stateMutability":"view","type":"function"}]','BLUR_STAKING');
INSERT INTO contract_data(rowid,address,chain_id,abi,deployed_block) VALUES(168,'0xeC2432a227440139DDF1044c3feA7Ae03203933E',1,90,18601207);

@moxw moxw added the ready for peer review Backend PR ready to be reviewed by colleagues label May 5, 2024
Copy link

codecov bot commented May 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.53%. Comparing base (f30ee51) to head (e30ece6).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #7886       +/-   ##
============================================
- Coverage    80.74%   53.53%   -27.22%     
============================================
  Files         1197     1651      +454     
  Lines       108493   166546    +58053     
  Branches     12990    13466      +476     
============================================
+ Hits         87608    89158     +1550     
- Misses       18616    75119    +56503     
  Partials      2269     2269               
Flag Coverage Δ
frontend_integration 58.79% <ø> (-0.96%) ⬇️
frontend_unit 38.92% <ø> (-40.62%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rotkehlchen/chain/ethereum/modules/blur/decoder.py Outdated Show resolved Hide resolved
rotkehlchen/chain/ethereum/modules/blur/decoder.py Outdated Show resolved Hide resolved
rotkehlchen/chain/ethereum/modules/blur/decoder.py Outdated Show resolved Hide resolved
rotkehlchen/chain/ethereum/modules/blur/decoder.py Outdated Show resolved Hide resolved
rotkehlchen/chain/ethereum/modules/blur/decoder.py Outdated Show resolved Hide resolved
rotkehlchen/tests/unit/decoders/test_blur.py Outdated Show resolved Hide resolved
rotkehlchen/chain/ethereum/modules/blur/balances.py Outdated Show resolved Hide resolved
rotkehlchen/chain/ethereum/modules/blur/balances.py Outdated Show resolved Hide resolved
rotkehlchen/chain/ethereum/modules/blur/balances.py Outdated Show resolved Hide resolved
@yabirgb yabirgb added PR review work work on PR review comments and removed ready for peer review Backend PR ready to be reviewed by colleagues labels May 7, 2024
@moxw moxw force-pushed the decode-blur-staking branch 2 times, most recently from a0a6631 to 1190cfd Compare May 12, 2024 07:44
@moxw moxw requested a review from yabirgb May 12, 2024 07:45
@yabirgb yabirgb added ready for peer review Backend PR ready to be reviewed by colleagues and removed PR review work work on PR review comments labels May 13, 2024
rotkehlchen/chain/ethereum/modules/blur/decoder.py Outdated Show resolved Hide resolved
rotkehlchen/chain/ethereum/modules/blur/decoder.py Outdated Show resolved Hide resolved
rotkehlchen/chain/ethereum/modules/blur/decoder.py Outdated Show resolved Hide resolved
rotkehlchen/chain/ethereum/modules/blur/decoder.py Outdated Show resolved Hide resolved
rotkehlchen/chain/ethereum/modules/blur/balances.py Outdated Show resolved Hide resolved
@yabirgb yabirgb added PR review work work on PR review comments and removed ready for peer review Backend PR ready to be reviewed by colleagues labels May 21, 2024
@moxw moxw added ready for peer review Backend PR ready to be reviewed by colleagues and removed PR review work work on PR review comments labels May 22, 2024
@moxw moxw force-pushed the decode-blur-staking branch 3 times, most recently from 28e557a to 94a885d Compare May 22, 2024 17:05
@yabirgb yabirgb added ready for final review Backend PR ready to be reviewed by great Lefteris and removed ready for peer review Backend PR ready to be reviewed by colleagues labels May 22, 2024
rotkehlchen/chain/ethereum/modules/airdrops/decoder.py Outdated Show resolved Hide resolved
rotkehlchen/chain/ethereum/modules/blur/balances.py Outdated Show resolved Hide resolved
rotkehlchen/chain/ethereum/modules/blur/balances.py Outdated Show resolved Hide resolved
rotkehlchen/constants/assets.py Outdated Show resolved Hide resolved
@LefterisJP LefterisJP added PR review work work on PR review comments and removed ready for final review Backend PR ready to be reviewed by great Lefteris labels May 23, 2024
@moxw moxw added ready for final review Backend PR ready to be reviewed by great Lefteris and removed PR review work work on PR review comments labels May 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 23, 2024

Codecov Report

Attention: Patch coverage is 82.30088% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 49.84%. Comparing base (f30ee51) to head (e30ece6).
Report is 4 commits behind head on develop.

Files Patch % Lines
rotkehlchen/chain/ethereum/modules/blur/decoder.py 81.03% 5 Missing and 6 partials ⚠️
...otkehlchen/chain/ethereum/modules/blur/balances.py 79.06% 7 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #7886       +/-   ##
============================================
- Coverage    80.74%   49.84%   -30.91%     
============================================
  Files         1197     1654      +457     
  Lines       108493   166742    +58249     
  Branches     12990    13501      +511     
============================================
- Hits         87608    83118     -4490     
- Misses       18616    81434    +62818     
+ Partials      2269     2190       -79     
Flag Coverage Δ
backend 69.45% <82.30%> (-11.52%) ⬇️
frontend_integration 59.93% <ø> (+0.18%) ⬆️
frontend_unit 38.92% <ø> (-40.62%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@LefterisJP LefterisJP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LefterisJP LefterisJP merged commit b67531f into rotki:develop May 23, 2024
15 checks passed
@rotkibot
Copy link

rotki/test-caching/tree/decode-blur-staking was successfully merged

@moxw moxw deleted the decode-blur-staking branch May 28, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for final review Backend PR ready to be reviewed by great Lefteris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants