Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: unify account management #7527

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

kelsos
Copy link
Member

@kelsos kelsos commented Feb 22, 2024

Closes #(issue_number)
Closes #5988

Checklist

  • The PR modified the frontend, and updated the user guide to reflect the changes.

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 75.54427% with 337 lines in your changes missing coverage. Please review.

Project coverage is 53.77%. Comparing base (bb171aa) to head (a9344f3).
Report is 1 commits behind head on develop.

Files Patch % Lines
...rontend/app/src/utils/blockchain/accounts/index.ts 59.33% 98 Missing ⚠️
...p/src/components/accounts/AccountBalancesTable.vue 85.52% 44 Missing ⚠️
...p/src/store/blockchain/accounts/addresses-names.ts 84.64% 37 Missing ⚠️
...d/app/src/composables/blockchain/accounts/index.ts 21.87% 25 Missing ⚠️
frontend/app/src/store/blockchain/index.ts 86.09% 21 Missing ⚠️
...src/components/accounts/management/AccountForm.vue 0.00% 17 Missing ⚠️
...s/accounts/management/types/AddressAccountForm.vue 0.00% 17 Missing ⚠️
...app/src/composables/blockchain/accounts/staking.ts 6.66% 14 Missing ⚠️
...nd/app/src/components/accounts/AccountBalances.vue 89.51% 13 Missing ⚠️
...ontend/app/src/pages/balances/blockchain/index.vue 0.00% 13 Missing ⚠️
... and 12 more
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #7527       +/-   ##
============================================
- Coverage    80.63%   53.77%   -26.86%     
============================================
  Files         1215     1671      +456     
  Lines       108569   167325    +58756     
  Branches     13104    13692      +588     
============================================
+ Hits         87541    89977     +2436     
- Misses       18721    75041    +56320     
  Partials      2307     2307               
Flag Coverage Δ
frontend_integration 60.19% <62.98%> (+0.59%) ⬆️
frontend_unit 39.12% <72.78%> (-40.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kelsos kelsos force-pushed the accounts branch 3 times, most recently from 3e9b004 to 9547df2 Compare April 8, 2024 17:01
@kelsos kelsos force-pushed the accounts branch 5 times, most recently from e25f4b1 to 66d9dc6 Compare April 18, 2024 13:34
@kelsos kelsos force-pushed the accounts branch 4 times, most recently from 625d276 to 7f63811 Compare April 25, 2024 12:55
@kelsos kelsos force-pushed the accounts branch 4 times, most recently from f97b277 to 60e7327 Compare May 3, 2024 07:55
@kelsos kelsos force-pushed the accounts branch 3 times, most recently from f489e36 to 282dfe9 Compare May 8, 2024 15:46
@kelsos kelsos force-pushed the accounts branch 7 times, most recently from 1facc30 to f0316dc Compare May 17, 2024 17:35
@kelsos
Copy link
Member Author

kelsos commented May 17, 2024

Functionality wise the only thing remaining is to ensure that the display label is considered when sorting or filtering.

@kelsos kelsos force-pushed the accounts branch 5 times, most recently from 8b67cce to 6bfa3ac Compare June 3, 2024 11:47
@kelsos kelsos marked this pull request as ready for review June 3, 2024 11:54
@kelsos
Copy link
Member Author

kelsos commented Jun 3, 2024

We can add a list here of the things that need fix

  • Alignment of total broken in group/details (pending fix)
  • Editing validator and updated ownership percentage seems weird
  • All evm chains checkbox is broken
  • Change tags to filter the same way as chains
  • Cannot add xpub
  • Validation error recovery when adding a new account

@kelsos kelsos force-pushed the accounts branch 3 times, most recently from 8f58f22 to ed70b36 Compare June 4, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve search by allowing searching by address
1 participant