Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yolo test_callback_segfault_simple #7218

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

LefterisJP
Copy link
Member

No description provided.

@LefterisJP LefterisJP force-pushed the testity_test branch 2 times, most recently from 56cd762 to 6090af4 Compare January 3, 2024 11:47
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4a33dfb) 73.46% compared to head (06858b7) 73.21%.
Report is 8 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7218      +/-   ##
===========================================
- Coverage    73.46%   73.21%   -0.26%     
===========================================
  Files         1236     1236              
  Lines       106595   106245     -350     
  Branches     12390    12336      -54     
===========================================
- Hits         78310    77783     -527     
- Misses       26410    26589     +179     
+ Partials      1875     1873       -2     
Flag Coverage Δ
backend 67.50% <ø> (-0.52%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LefterisJP
Copy link
Member Author

Test passed on its own

@LefterisJP LefterisJP force-pushed the testity_test branch 3 times, most recently from 94aa280 to 47784d3 Compare January 3, 2024 19:24
@LefterisJP
Copy link
Member Author

This shit won''t fail. Tried rotkehlchen/tests/test_no_missing_init.py rotkehlchen/tests/test_users.py rotkehlchen/tests/data_migrations/ rotkehlchen/tests/db/ now and passed.

@LefterisJP
Copy link
Member Author

Running the entire "others" backend tests makes it fail: python pytestgeventwrapper.py $PYTEST_ARGS $COVERAGE_ARGS --ignore=rotkehlchen/tests/api rotkehlchen/tests/

@LefterisJP
Copy link
Member Author

Okay made it fail nicely and fast by python pytestgeventwrapper.py $PYTEST_ARGS $COVERAGE_ARGS -x --ignore=rotkehlchen/tests/api rotkehlchen/tests/

Unfortunately only on the CI

@LefterisJP
Copy link
Member Author

By reverting the urlib3 change test passes ofc, so it's definitely that.

2024-01-03_23-49

@LefterisJP
Copy link
Member Author

Canceled the workflow as it passed the test without failing. So adding TRACE logging makes it not happen. Which ... helps us not.

@LefterisJP LefterisJP force-pushed the testity_test branch 2 times, most recently from d954288 to debd219 Compare January 3, 2024 23:30
@LefterisJP
Copy link
Member Author

Even increasing the events and decreasing sql_vm_instructions_cb makes this pass. Canceled the workflow again.

@LefterisJP
Copy link
Member Author

Okay nice so going back to no trace and no test changes reproduces immediately. At least that's something. Wish I could do this locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant