Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip single moves #1211

Draft
wants to merge 8 commits into
base: source
Choose a base branch
from
Draft

Skip single moves #1211

wants to merge 8 commits into from

Conversation

rossjrw
Copy link
Owner

@rossjrw rossjrw commented Oct 26, 2021

When there is only a single move to make, there is no choice for a player and therefore what little fun this game has is removed. In this situation, the move should be made automatically.

Resolves #1123; closes #1293.

  • Perform the move automatically if there's only a single choice
  • Do not move automatically if that move is a winning move (a player should be allowed to claim that themselves)
  • Report a summary of all executed moves in the reply to the issue, including any passes
  • In the reply, if the resultant turn is the same colour as the team of the player who made the issue, let them know that they can make another move
    • This can happen via automatic passes, automatic moves as a result of this PR, or rosettes
  • Show automatic moves in the main log correctly
    • Do not incorrectly attribute them to the current player
    • The code currently assumes that if the move is a pass, it was made by the game and everything else is done by a player - either this needs to be corrected with explicit data, or another assumption can be
      • The log does not currently distinguish between explicit actions and automatic actions
      • One possible assumption could be that only the first move made on a player's turn can be attributed to that player and all subsequent moves can be attributed to the game (not currently feasible - turns are counted by the number of actions)

@rossjrw
Copy link
Owner Author

rossjrw commented Oct 30, 2021

I need to be careful about the tense of the events I summarise, and be precise enough:

E.g.:

Done! You moved a black piece from position 4 to position 8. You claimed a rosette, so you can take another turn!

The black team rolled a 0 and was forced to pass.

It's white to play.

would be misleading, because it says you can take anothe.r turn, but actually you can't.

This would be more appropriate, as the rosette message isn't specific in its description:

Done! You moved a black piece from position 4 to position 8. You claimed a rosette, giving the black team another turn.

The black team rolled a 0 and was forced to pass.

It's white to play.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant