Add ability to configure scenes for lights #1357
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcm0116
force-pushed
the
add_light_scene_config
branch
from
7e62470
to
ffc3a04
Compare
|
I want this! I think we all want this! Please merge, please 💯 |
|
@rospogrigio - I've been using this change successfully for over a year. Any interest in merging it? |
tcm0116
force-pushed
the
add_light_scene_config
branch
from
7374ed6
to
e0f74d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, assumptions are made about which scene options are available for lights. This PR adds the ability to optionally configure the scene list. Below is a screenshot of the new fields which are added to the configuration screen for lights.
For the case of my string lights (HVS Smart Outdoor String Lights), I use the following values:
white;colour;scene1;scene2;scene3;scene4;scene5;scene6;scene7;scene8;scene9White;Color;Strobe;Fade;Pulse;Blink;Chase;Christmas;America;Pick 2;MultiI believe this will address the following issues: