Add doc comments to R__ASSERT/CHECK #15559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jblomer
approved these changes
May 17, 2024
pcanal
reviewed
May 17, 2024
pcanal
reviewed
May 17, 2024
pcanal
reviewed
May 17, 2024
Test Results 11 files 11 suites 2d 8h 59m 18s ⏱️ Results for commit b1cdae8. ♻️ This comment has been updated with latest results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request:
Adds brief documentation to
R__ASSERTandR__CHECKunderlining how they do not get stripped in release mode (which might be unexpected for some users).Additionally, it uses
R__likelyfor the check itself, since the condition is expected to be true.Checklist: