[webgui] fix handling of local displays like qt5 or cef #15550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For qt5/qt6/cef displays new page request appears faster then previous connection will be regularly closed. Therefore when verify key by html page loading also checks new keys for the valid connections.
Test Results 11 files 11 suites 2d 7h 33m 34s ⏱️ Results for commit d055f9d. |
bellenot
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reloading web widget in QT5/QT6/CEF widget,
new widget loads faster than old connection is closed.
Therefore allow new key checks when loading HTML page
Remove debug output from firefox start script