object: update cosi images #14216
object: update cosi images #14216
Conversation
thotz
requested review from
BlaineEXE and
travisn
and removed request for
BlaineEXE
thotz
force-pushed
the
update-cosi-images
branch
2 times, most recently
from
e1cacc8
to
c145df4
Compare
| @@ -2,7 +2,7 @@ kind: BucketClass | |||
| apiVersion: objectstorage.k8s.io/v1alpha1 | |||
| metadata: | |||
| name: sample-bcc | |||
| driverName: ceph.objectstorage.k8s.io | |||
| driverName: rook-ceph.ceph.objectstorage.k8s.io | |||
There was a problem hiding this comment.
How will this change affect upgraded clusters?
There was a problem hiding this comment.
Yaa it will impact the upgraded clusters, even with a standalone ceph cosi driver as well. Please check @BlaineEXE comment ceph/ceph-cosi#32 (comment) and make the ceph cosi driver mandate the driver prefix.
There was a problem hiding this comment.
I think that's fine. COSI is an alpha feature, so users should expect potential changes. We'd have to maintain code logic to check for this upgrade condition forever if we want to support no-impact upgrades.
It would be nice to know what users have to do to upgrade though, and what users need to do to allow existing COSI buckets to continue working after the change.
There was a problem hiding this comment.
Does this mean existing COSI users will be broken on upgrade? Is there any workaround? We will at least need a note on this in the upgrade guide for 1.15. Even though it's officially alpha and rook still declares it as experimental, I'd suggest we document when there is a breaking change.
There was a problem hiding this comment.
Right. I forgot about existing buckets initially, but you are right. It is still best for users if we document in release notes when things break, and we should be able to document a procedure for continuing to work with existing storage wherever possible.
I don't think that we need to have an official doc that explains how to make the change, but it would be good to at least be able to link to something on github. Maybe a discussion post that describes the workflow needed to keep existing buckets working would be a good option.
| @@ -2,5 +2,7 @@ | |||
|
|
|||
| ## Breaking Changes | |||
|
|
|||
| - Updating Ceph COSI driver images, this impact existing COSI `Buckets` and `BucketAccesses`, | |||
| please update the `BucketClass` and `BucketAccessClass` for resolving refer [here](https://github.com/rook/rook/discussions/14297) | |||
There was a problem hiding this comment.
There will be upgrade steps added to this issue?
There was a problem hiding this comment.
The discussion is sparse. Could you provide a more detailed set of instructions for users to follow along?
Doesn't this also affect any BucketClaims and BucketAccesses that are created? What about those?
Updating images for ceph cosi driver and side car. Signed-off-by: Jiffin Tony Thottan <[email protected]>
Updating images for ceph cosi driver and side car.
Checklist: