Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(replace): fix replace for ternary operators #1712

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

smnhgn
Copy link
Contributor

@smnhgn smnhgn commented Apr 21, 2024

Rollup Plugin Name: @rollup/plugin-replace

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

resolves #1619

Description

Instead of treating : as an assignment operator we can check for certain keywords (const, let, var) which normally occur before an assignment. This should handle typescript assignments with types as well as ternary operators.

@smnhgn smnhgn requested a review from shellscape as a code owner April 21, 2024 18:50
Copy link
Collaborator

@shellscape shellscape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@shellscape shellscape merged commit ee8b432 into rollup:master Jun 5, 2024
5 checks passed
younggglcy pushed a commit to younggglcy/plugins that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants