Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update release flow to use changesets. #577

Merged
merged 25 commits into from Mar 14, 2024
Merged

feat: Update release flow to use changesets. #577

merged 25 commits into from Mar 14, 2024

Conversation

milesj
Copy link
Contributor

@milesj milesj commented Mar 13, 2024

Description

Closes #576
Closes #543

Test Plan


Copy link

netlify bot commented Mar 13, 2024

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 46f19ab
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/65f33588407d710008c8506d

@milesj milesj changed the title WIP: Update release flow. feat: Update release flow to use changesets. Mar 13, 2024
@@ -30,5 +30,9 @@
"fileMatch": ["test.config.json"],
"url": "./crates/rolldown_testing/test.config.scheme.json"
}
]
],
"search.exclude": {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know about y'all, but I hate these folders showing up in search.

Copy link

codspeed-hq bot commented Mar 13, 2024

CodSpeed Performance Report

Merging #577 will not alter performance

Comparing release-log (46f19ab) with main (09f7cc8)

Summary

✅ 4 untouched benchmarks

Copy link

changeset-bot bot commented Mar 14, 2024

⚠️ No Changeset found

Latest commit: 46f19ab

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hyf0
Copy link
Member

hyf0 commented Mar 14, 2024

⚠️ No Changeset found

Latest commit: 4c8dc3a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets
Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

we only use changeset for bumping version. This comment is useless, probably should disable it. This should also apply for Changesets Status action. Should remove it too.

Copy link
Member

@hyf0 hyf0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful!

@hyf0 hyf0 merged commit a4f50dd into main Mar 14, 2024
11 checks passed
@hyf0 hyf0 deleted the release-log branch March 14, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate from Yarn / Lerna to pnpm
3 participants