feat: migrate from yarn to pnpm #567
Conversation
✅ Deploy Preview for rolldown-rs canceled.
|
package.json
Outdated
| "scripts": { | ||
| "nuke": "rm -rf node_modules && rm -rf packages/*/node_modules && rm -rf web/*/node_modules && rm -rf examples/*/node_modules && rm -rf crates/rolldown_binding_wasm/node_modules && rm -rf scripts/node_modules", |
| @@ -105,6 +106,15 @@ async function runRollup(item) { | |||
| for (const suite of suites) { | |||
| const bench = new Bench({ time: 100, iterations: suite.benchIteration ?? 10 }) | |||
|
|
|||
| // Check if inputs have been initialized | |||
| for (const input of suite.inputs) { | |||
There was a problem hiding this comment.
When testing, this would crash hard if just setup-bench wasn't ran, so added this little check.
| "@types/node": "^20.11.25", | ||
| "npm-run-all2": "^6.1.2", | ||
| "prettier": "^3.2.5", | ||
| "colorette": "^2.0.20", |
There was a problem hiding this comment.
There are used in tests, but weren't listed. Because pnpm scopes them, they're now required.
| @@ -1,4 +1,4 @@ | |||
| import type { RollupOptions, RollupOutput } from 'rolldown' | |||
| import type { RollupOptions } from '../../../../src' | |||
There was a problem hiding this comment.
Because of pnpm, rolldown was no longer able to reference itself, so had to use relative paths.
.github/workflows/ci.yml
Outdated
| - name: Install pnpm | ||
| run: corepack enable | ||
|
|
||
| - name: Install pnpm | ||
| run: corepack enable |
There was a problem hiding this comment.
This is duplicated.
actions/cache needed to cache pnpm packages, so they are not downloaded every time.
|
Dependencies install in less than 45 seconds, typically around 15-20. Not really worth adding caching at this point. |
Why not make it even faster? It is just 4–5 lines of CI code. |
|
@milesj Do you have time to clean up this PR? So we could merge the migration first. We could solve release problems in another PR. I saw the c-spell job failed. You could add the issue file to |
|
Let me take it from here. I will comment out the release ci for temp. |
hyf0
changed the title
|
Downloading and unpacking an archive over the network will still take similar times. Caching isn't really necessary. |
Description
Part of #543
This PR does a bunch of things:
package.json, and removed deps that weren't used, or should be in the root.Test Plan