Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 multi-declaration test #1070

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

IWANABETHATGUY
Copy link
Contributor

Description

Copy link

netlify bot commented May 9, 2024

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit c267a87
🔍 Latest deploy log https://app.netlify.com/sites/rolldown-rs/deploys/663f5cc47081a40008ad9809

Copy link

codspeed-hq bot commented May 9, 2024

CodSpeed Performance Report

Merging #1070 will not alter performance

Comparing fix/multi-declaration (c267a87) with main (bd851a9)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.16%. Comparing base (bd851a9) to head (c267a87).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1070   +/-   ##
=======================================
  Coverage   87.16%   87.16%           
=======================================
  Files         118      118           
  Lines        5907     5907           
=======================================
  Hits         5149     5149           
  Misses        758      758           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 9, 2024

Benchmarks Rust

group                                      pr                                     target
-----                                      --                                     ------
rolldown benchmark/threejs-bundle          1.03     32.1±0.98ms        ? ?/sec    1.00     31.2±0.26ms        ? ?/sec
rolldown benchmark/threejs-scan            1.01     22.3±0.79ms        ? ?/sec    1.00     22.0±1.06ms        ? ?/sec
rolldown benchmark/threejs-sourcemap       1.01     44.0±0.60ms        ? ?/sec    1.00     43.7±0.59ms        ? ?/sec
rolldown benchmark/threejs10x-bundle       1.02    329.1±4.05ms        ? ?/sec    1.00    321.7±3.51ms        ? ?/sec
rolldown benchmark/threejs10x-scan         1.01    212.1±2.88ms        ? ?/sec    1.00    210.5±3.74ms        ? ?/sec
rolldown benchmark/threejs10x-sourcemap    1.01   449.0±12.63ms        ? ?/sec    1.00    445.3±8.62ms        ? ?/sec

Benchmarks Rust

group                                      pr                                     target
-----                                      --                                     ------
rolldown benchmark/threejs-bundle          1.03     30.1±0.53ms        ? ?/sec    1.00     29.1±0.29ms        ? ?/sec
rolldown benchmark/threejs-scan            1.00     20.8±0.46ms        ? ?/sec    1.00     20.8±0.66ms        ? ?/sec
rolldown benchmark/threejs-sourcemap       1.04     41.9±3.43ms        ? ?/sec    1.00     40.5±0.53ms        ? ?/sec
rolldown benchmark/threejs10x-bundle       1.00    310.8±2.59ms        ? ?/sec    1.00    310.8±4.29ms        ? ?/sec
rolldown benchmark/threejs10x-scan         1.00    204.7±1.77ms        ? ?/sec    1.00    203.8±5.85ms        ? ?/sec
rolldown benchmark/threejs10x-sourcemap    1.02   432.3±11.25ms        ? ?/sec    1.00    425.5±7.76ms        ? ?/sec

Benchmarks Rust

group                                      pr                                     target
-----                                      --                                     ------
rolldown benchmark/threejs-bundle          1.00     29.5±0.38ms        ? ?/sec    1.00     29.6±0.54ms        ? ?/sec
rolldown benchmark/threejs-scan            1.01     21.0±0.14ms        ? ?/sec    1.00     20.7±0.13ms        ? ?/sec
rolldown benchmark/threejs-sourcemap       1.02     41.5±1.94ms        ? ?/sec    1.00     40.7±0.77ms        ? ?/sec
rolldown benchmark/threejs10x-bundle       1.00    315.6±2.72ms        ? ?/sec    1.00    315.6±3.17ms        ? ?/sec
rolldown benchmark/threejs10x-scan         1.00    207.1±2.31ms        ? ?/sec    1.00    207.6±3.38ms        ? ?/sec
rolldown benchmark/threejs10x-sourcemap    1.00    434.3±8.68ms        ? ?/sec    1.00    432.7±8.35ms        ? ?/sec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant