imshowパッケージをc++からpythonに変更 #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
H1rono
requested changes
Jun 23, 2024
There was a problem hiding this comment.
これ消さないで欲しいです
提供するnodeとexecutableは変わらないので、記述を変える必要もない
There was a problem hiding this comment.
フォーマットが気になるので、可能なら整形しておきたい
参考: PEP8
There was a problem hiding this comment.
具体的には、
importとclassの間は空行2行class内の関数定義間は空行1行- 関数呼び出しの引数リストで
,の後に空白1マスを入れる
Comment on lines
+10
to
+13
| <test_depend>ament_copyright</test_depend> | ||
| <test_depend>ament_flake8</test_depend> | ||
| <test_depend>ament_pep257</test_depend> | ||
| <test_depend>python3-pytest</test_depend> |
There was a problem hiding this comment.
Suggested change
| <test_depend>ament_copyright</test_depend> | |
| <test_depend>ament_flake8</test_depend> | |
| <test_depend>ament_pep257</test_depend> | |
| <test_depend>python3-pytest</test_depend> | |
| <exec_depend>rclpy</exec_depend> | |
| <exec_depend>sensor_msgs</exec_depend> | |
| <exec_depend>cv_bridge</exec_depend> |
Comment on lines
+13
to
+14
| description='Image display for ROS2', | ||
| license='MIT license', |
There was a problem hiding this comment.
これだけだとlaunchファイルがビルド結果に含まれないので、そこの記述を足してください
↓記述例
2024_cavolinia/device/joystick/setup.py
Lines 12 to 17 in 5b8493e
There was a problem hiding this comment.
これを足すとimportが足りなくなるのでそれも忘れずに(これも記述例参照)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.