Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camera reader #13

Merged
merged 17 commits into from
Jun 14, 2024
Merged

Camera reader #13

merged 17 commits into from
Jun 14, 2024

Conversation

23-yoshikawa
Copy link
Contributor

No description provided.

device/camera_reader/package.xml Outdated Show resolved Hide resolved
device/camera_reader/CMakeLists.txt Outdated Show resolved Hide resolved
device/camera_reader/CMakeLists.txt Outdated Show resolved Hide resolved
device/camera_reader/package.xml Show resolved Hide resolved
device/camera_reader/src/camera_reader.cpp Show resolved Hide resolved
device/camera_reader/src/camera_reader.cpp Outdated Show resolved Hide resolved
device/camera_reader/src/camera_reader.cpp Outdated Show resolved Hide resolved
@H1rono H1rono mentioned this pull request Jun 4, 2024
@H1rono H1rono linked an issue Jun 5, 2024 that may be closed by this pull request
@23-yoshikawa 23-yoshikawa requested a review from H1rono June 10, 2024 12:30
Copy link
Member

@H1rono H1rono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

良さそう!あと、README.mdを置いて欲しいです
記述例: https://github.com/rogy-AquaLab/2024_cavolinia/blob/cbd4ca5/device/pi_i2c/README.md
今はLaunchがないので、NodeとExecutableだけ書いてください

@H1rono
Copy link
Member

H1rono commented Jun 10, 2024

launchファイルも書けるなら書いて欲しいです。具体的には↓の内容で

  • camera_readerexecutableを実行する
  • devicenamespaceを設定

@23-yoshikawa
Copy link
Contributor Author

launchファイルは.pyで、pi_i2cを参考に書けばよろしいですか

@23-yoshikawa 23-yoshikawa requested a review from H1rono June 13, 2024 04:51
Copy link
Member

@H1rono H1rono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

あとlaunchと動作確認

Copy link
Member

@H1rono H1rono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

@H1rono H1rono merged commit c97b85b into main Jun 14, 2024
1 check passed
@H1rono H1rono deleted the camera_reader branch June 14, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

camera Node
2 participants