Don't try to divide by zero if CPU scaling frequency min and max are equal #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… dividing by zero
…eason; bad configuration should not be masked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just built and installed powerkit for the first time. When I tried to open the config GUI, it crashed with a floating point exception. I tracked down the issue to line 430 in
powerkit_cpu.cpp, which calculates the current CPU frequency as a percentage within the configured scaling range. My min and max values are equal, so this leads to a division by zero. This PR handles this corner case (I interpreted it as 100% progress).