Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MultipartFileRecreatable.fromBytes + plugin improvements #29

Merged
merged 6 commits into from
Oct 26, 2023

Conversation

Zazo032
Copy link
Contributor

@Zazo032 Zazo032 commented May 2, 2023

Fixes #27

6.0.0

  • Updated internal libraries.
  • Bumped minimum Dart SDK to 3.0.
  • Added MultipartFileRecreatable documentation.
  • Refactors static constructors to factories.
  • Adds a new MultipartFileRecreatable.fromBytes factory compatible with web.
  • Added a new headers parameter.
  • You can now read the file's content with MultipartFileRecreatable.data.
  • Breaking: MultipartFileRecreatable.filename is now a named parameter to match dio.
  • Breaking: Removed MultipartFileRecreatable.filePath since it was not being used internally.

@Zazo032
Copy link
Contributor Author

Zazo032 commented May 2, 2023

@rodion-m I noticed running flutter test doesn't run all the tests in the repo because the file's are not using the proper format (<test>_test.dart), it should be fixed in a different PR

@Zazo032
Copy link
Contributor Author

Zazo032 commented Jul 25, 2023

@rodion-m do you think this could get reviewed anytime soon? We've been using it in production for a couple months now

@rodion-m
Copy link
Owner

rodion-m commented Jul 26, 2023

do you think this could get reviewed anytime soon? We've been using it in production for a couple months now

Hello! Sorry for the delay, I was too busy at work. You did a great job, thank you for this. Since your PR makes breaking changes, could you please add information in the README about moving from version 5.0 to 5.1?

@Zazo032
Copy link
Contributor Author

Zazo032 commented Oct 26, 2023

@rodion-m done 🙂

Copy link
Owner

@rodion-m rodion-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot for your contribution!

@rodion-m rodion-m merged commit 810d213 into rodion-m:master Oct 26, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support MultipartFileRecreatable on the web
2 participants