delete the objects owned by the widget #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doudou
reviewed
Jan 16, 2019
| Vizkit3DWidget::~Vizkit3DWidget() | ||
| { | ||
| delete env_plugin; | ||
| env_plugin = NULL; |
There was a problem hiding this comment.
Since you're using C++ >= 11, use nullptr instead of NULL.
|
Vizkit3DWidget sets its plugin parent (as QObject parent) to itself here: https://github.com/rock-core/gui-vizkit3d/blob/master/src/Vizkit3DWidget.cpp#L751 Qt will therefore delete the plugin when their parent (the vizkit3dWidget) gets deleted, and this is not needed. |
|
Since there is a difference in behavior between explicit deletion and letting-Qt-doing-it, there's something else that's fishy. Let's leave this PR open until we figure out what it is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.