Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/zulip block formatting #1404

Merged
merged 1 commit into from
May 16, 2024
Merged

Fix/zulip block formatting #1404

merged 1 commit into from
May 16, 2024

Conversation

oscgu
Copy link
Contributor

@oscgu oscgu commented May 6, 2024

The last arg in __to_zulip_block() should be the format, if anything, or else you end up with unreadable messages

arikalon1
arikalon1 approved these changes May 12, 2024
View reviewed changes
Copy link
Contributor

@arikalon1 arikalon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @oscgu , looks good

Unrelated to this fix, but why are you using yield?

@oscgu
Copy link
Contributor Author

oscgu commented May 12, 2024

Thanks @oscgu , looks good

Unrelated to this fix, but why are you using yield?

IMO it makes it easier to return 1..N strings from the func, without the need for some sort of temporary list.
The performance difference should be negligible too.
Should I have implemented it differently?

@arikalon1 arikalon1 merged commit 64a5246 into robusta-dev:master May 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arikalon1 arikalon1 arikalon1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oscgu @arikalon1