Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus workload loader #266

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Conversation

LeaveMyYard
Copy link
Contributor

@LeaveMyYard LeaveMyYard commented Apr 22, 2024

  • Implemented ability to select an alternative workload loader
  • Implemented Prometheus workload loader
  • Refactored Kube API workload loader: moved separate logic (for each Kind) to a separate class
  • List clusters on centralized prometheus
  • Scanning multiple clusters in prometheus mode?
  • Test running from robusta UI
  • Test prometheus mode on centralized prometheus
  • A lot of testing
  • Fix tests (mocks are now broken)

Testing issues found:

  • For some reason auto-discovery does not work
  • Prometheus mode does not gather HPA data
  • Something is now broken with HPAKey

@LeaveMyYard LeaveMyYard self-assigned this Apr 22, 2024
@LeaveMyYard LeaveMyYard mentioned this pull request Apr 26, 2024
3 tasks
@LeaveMyYard LeaveMyYard requested a review from aantn April 30, 2024 15:56
@LeaveMyYard LeaveMyYard marked this pull request as ready for review April 30, 2024 15:56
@deutschj
Copy link

When testing using the prometheus mode on a centralized Prometheus (VictoriaMetrics), I encountered the following errors.
I specified the labels --prometheus-label and --prometheus-cluster-label according to the docs:

python krr.py simple -p https://vmauth.xxx.com --prometheus-auth-header "<redacted>" --prometheus-label cluster -l k8s0-q --mode prometheus

image

To me it seems that the query includes the wrong label here, and should be avg by(cluster) instead of using the cluster name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants