Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chinese version of readme #9

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Chinese version of readme #9

wants to merge 3 commits into from

Conversation

ArtificialZeng
Copy link

Chinese version of readme

wangyenjen
wangyenjen requested changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@wangyenjen wangyenjen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ArtificialZeng,

Thank you for your contribution to the Chinese version of the README! We're delighted to see the Chinese translation. However, we noticed some broken Chinese, such as 跨 4096 环境启动“v1”PPO 政策训练. Could you please review the Chinese version of the README again, correct any errors, and ensure the semantics and grammar are accurate? Thank you!

@ArtificialZeng
Update README_CH.md
55229d3 
希望这次改对了。谢谢指出！ thank you for correcting me
@ArtificialZeng
Copy link
Author

Hi @ArtificialZeng,

Thank you for your contribution to the Chinese version of the README! We're delighted to see the Chinese translation. However, we noticed some broken Chinese, such as 跨 4096 环境启动“v1”PPO 政策训练. Could you please review the Chinese version of the README again, correct any errors, and ensure the semantics and grammar are accurate? Thank you!

noted, changed, thank you for correcting me.

@wangyenjen wangyenjen added the enhancement New feature or request label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangyenjen wangyenjen wangyenjen requested changes

@zlw21gxy zlw21gxy Awaiting requested review from zlw21gxy

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ArtificialZeng @wangyenjen