Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated inference_slicer.py #842

Conversation

Bhavay-2001
Copy link
Contributor

Description

Fixes #781

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How has this change been tested, please provide a testcase or example of how you tested the change?

Tests needs to be done.

Any specific deployment considerations

For example, documentation changes, usability, usage/costs, secrets, etc.

Docs

  • Docs updated? What were the changes:

@Bhavay-2001
Copy link
Contributor Author

Hi @SkalskiP, can you please review the PR now and let me know of the changes.
Thanks

@SkalskiP
Copy link
Collaborator

SkalskiP commented Feb 2, 2024

I'll try to take a look on Monday.

@Bhavay-2001
Copy link
Contributor Author

Sure. We can discuss and hopefully merge it next week.

@Bhavay-2001
Copy link
Contributor Author

Also @SkalskiP, if you are okay can I work on some of the issues that you are currently assigned to if you are okay since there are many. Please let me know. Thanks

@SkalskiP
Copy link
Collaborator

SkalskiP commented Feb 2, 2024

@Bhavay-2001 any specific issue that you are interested in?

@Bhavay-2001
Copy link
Contributor Author

Not any specific that I could think off. Can you suggest any which might be good for me as a beginner.
Thanks

@SkalskiP
Copy link
Collaborator

SkalskiP commented May 8, 2024

Hi, @Bhavay-2001 👋🏻 Ultimately, this task had many edge cases and hidden complexities, so we decided that the code supervision team should implement it. #1108 Thank you so much for the time you invested in this PR. I hope you will contribute to supervision again in the future. 🙏🏻

@SkalskiP SkalskiP closed this May 8, 2024
@Bhavay-2001
Copy link
Contributor Author

Hi @SkalskiP, any beginner friendly issue that I can solve?
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[InferenceSlicer] - allow batch size inference
2 participants