Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for unicode labels with new RichLabelAnnotator class #1116

Merged
merged 12 commits into from May 15, 2024

Conversation

jeslinpjames
Copy link
Contributor

Description

Issue #990

New class RichLabelAnnotator added and resolve_text_background_xyxy() function moved from LabelAnnotatorClass to utils.py in supervision\annotators

List any dependencies that are required for this change.

ImageDraw, ImageFont, Image from PIL

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How has this change been tested, please provide a testcase or example of how you tested the change?

Here is the Colab link with the new RichLabelAnnotator Class.

Any specific deployment considerations

For example, documentation changes, usability, usage/costs, secrets, etc.

Docs

  • Docs updated? What were the changes:

@onuralpszr onuralpszr self-requested a review April 18, 2024 05:42
@jeslinpjames
Copy link
Contributor Author

Hi @onuralpszr @SkalskiP, just wanted to nudge you on this PR when you have a moment. Thanks a lot!

@onuralpszr onuralpszr added documentation Improvements or additions to documentation api:annotator Annotators labels May 15, 2024
Copy link
Collaborator

@onuralpszr onuralpszr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I made documentation additions, I also wanted to test with my new collab to see work as intended. Another collaboration works but I also noticed init was missing in the code so I made sure it works as well.

@onuralpszr
Copy link
Collaborator

Hi @onuralpszr @SkalskiP, just wanted to nudge you on this PR when you have a moment. Thanks a lot!

I am also sorry for late review.

@onuralpszr
Copy link
Collaborator

@jeslinpjames merging in. Thank you for your work 🎉 🚀

@onuralpszr onuralpszr merged commit 1776bf1 into roboflow:develop May 15, 2024
9 checks passed
@jeslinpjames
Copy link
Contributor Author

Hi @onuralpszr @SkalskiP, just wanted to nudge you on this PR when you have a moment. Thanks a lot!

I am also sorry for late review.

Thanks for the merge and your review! No worries about the delay.

@LinasKo
Copy link
Collaborator

LinasKo commented May 20, 2024

Hi @onuralpszr, @jeslinpjames,

Apologies for the delay on our part. Despite it being merged, I wanted to look at the code now.

@onuralpszr
Copy link
Collaborator

@LinasKo do you want my version collab ? (for testing purpose)

@LinasKo
Copy link
Collaborator

LinasKo commented May 20, 2024

do you want my version collab ? (for testing purpose)

@onuralpszr, That would be good to have :)

@onuralpszr
Copy link
Collaborator

@LinasKo https://colab.research.google.com/drive/181UBDBR0oS3Y8ZAfj6rLVW168yvolm56?usp=sharing

@LinasKo
Copy link
Collaborator

LinasKo commented May 20, 2024

@onuralpszr, I'm getting a "you need access" message

@onuralpszr
Copy link
Collaborator

@onuralpszr, I'm getting a "you need access" message

oh let me fix it.

@onuralpszr
Copy link
Collaborator

@LinasKo link updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api:annotator Annotators documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants