Update Formula for Iosevka v3.7.1 #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for all styles listed in the documentation[1]. - Add all styles that are missing. - Change the order of the options to match the documentation[1]. - Rename "slant" to "slope" to match the documentation[1]. - Remove no longer supported styles - Add the required "menu"-weights to the fonts for the font names - Remove "with-experimental-compressed" because this is not a default option anymore. - Add a flag for named "--without-widths-extended" instead of the "with-experimental-extended" (no longer experimental) option and a flag "--without-widths-normal" to only build the extended width - Remove dependency on caryll/tap/otfcc-mac64 (no longer needed) - Remove TODO's for no longer existing styles [1] https://github.com/be5invis/Iosevka/blob/58c472342ba46ce86108e5c85890b06261fa11bd/README.md#build-your-own-style
robertgzr
approved these changes
Nov 2, 2020
| option "without-sans", "skip building the default sans variant" | ||
| option "with-slab", "additionally build the serif variant" | ||
| option "with-woff", "additionally build the webfonts (woff)" | ||
| option "with-woff2", "additionally build the webfonts (woff2)" | ||
| option "with-unhinted", "additionally build unhinted TTF" | ||
|
|
||
| option "with-no-ligation", "disable ligations" |
There was a problem hiding this comment.
should it be without-ligation and without-cv-ss?
I guess it makes sense to have it this way to keep iosevka's options intact, but from brew's perspective without- would be more "idiomatic" ^^
I'm fine with either just wanted to bring it up...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for all styles listed in the documentation[1].
option anymore.
"with-experimental-compressed" (no longer experimental) option and a
flag "--without-widths-normal" to only build the extended width
[1] https://github.com/be5invis/Iosevka/blob/58c472342ba46ce86108e5c85890b06261fa11bd/README.md#build-your-own-style