Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: stream timeouts #92

Merged
merged 3 commits into from
Aug 22, 2023
Merged

feature: stream timeouts #92

merged 3 commits into from
Aug 22, 2023

Conversation

rustatian
Copy link
Member

Reason for This PR

ref: roadrunner-server/roadrunner#923
CC: @roxblnfk

Description of Changes

  • Add stream timeout pool option.
  • Fix worker stream behavior.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

Signed-off-by: Valery Piashchynski <[email protected]>
@rustatian rustatian added the C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc.. label Aug 22, 2023
@rustatian rustatian requested a review from wolfy-j August 22, 2023 20:48
@rustatian rustatian self-assigned this Aug 22, 2023
Signed-off-by: Valery Piashchynski <[email protected]>
Signed-off-by: Valery Piashchynski <[email protected]>
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #92 (caf555a) into master (d4175c2) will decrease coverage by 1.44%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##           master      #92      +/-   ##
==========================================
- Coverage   79.36%   77.92%   -1.44%     
==========================================
  Files          23       23              
  Lines        2006     2043      +37     
==========================================
  Hits         1592     1592              
- Misses        363      399      +36     
- Partials       51       52       +1     
Files Changed Coverage Δ
worker/worker.go 71.31% <16.66%> (-6.31%) ⬇️
payload/payload.go 40.00% <25.00%> (-60.00%) ⬇️
pool/static_pool/workers_pool.go 69.81% <28.57%> (-0.32%) ⬇️
pool/static_pool/debug.go 28.81% <50.00%> (+0.94%) ⬆️
pool/config.go 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@rustatian rustatian merged commit 9793e69 into master Aug 22, 2023
7 of 8 checks passed
@rustatian rustatian deleted the fix/stream-timeouts branch August 22, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc..
Projects
No open projects
Status: Unreleased
Status: SPRINT-21AUG-18SEP
1 participant