fixed crash in android, layer not added in maps with 3D themes #3450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ignaciotcrespo
had a problem deploying
to
CI with Mapbox Tokens
GitHub Actions
Error
ignaciotcrespo
had a problem deploying
to
CI with Mapbox Tokens
GitHub Actions
Error
ignaciotcrespo
had a problem deploying
to
CI with Mapbox Tokens
GitHub Actions
Error
ignaciotcrespo
had a problem deploying
to
CI with Mapbox Tokens
GitHub Actions
Error
ignaciotcrespo
had a problem deploying
to
CI with Mapbox Tokens
GitHub Actions
Error
ignaciotcrespo
had a problem deploying
to
CI with Mapbox Tokens
GitHub Actions
Error
|
@ignaciotcrespo thanks much for the PR, can you please add a simple standalone component reproducing the issue, thanks? |
hi @mfazekas it occurs exclusively on a client-specific map, which I cannot share due to proprietary restrictions. |
ignaciotcrespo
had a problem deploying
to
CI with Mapbox Tokens
GitHub Actions
Failure
ignaciotcrespo
had a problem deploying
to
CI with Mapbox Tokens
GitHub Actions
Failure
ignaciotcrespo
temporarily deployed
to
CI with Mapbox Tokens
GitHub Actions
Inactive
ignaciotcrespo
temporarily deployed
to
CI with Mapbox Tokens
GitHub Actions
Inactive
ignaciotcrespo
temporarily deployed
to
CI with Mapbox Tokens
GitHub Actions
Inactive
ignaciotcrespo
temporarily deployed
to
CI with Mapbox Tokens
GitHub Actions
Inactive
mfazekas
reviewed
Apr 27, 2024
| @@ -217,7 +216,11 @@ abstract class RNMBXLayer<T : Layer?>(protected var mContext: Context) : Abstrac | |||
| } | |||
| val layer = mLayer ?: return | |||
| val mapView = mMapView ?: return | |||
| style.addLayerAt(layer, index) | |||
| if(index < 0) { | |||
There was a problem hiding this comment.
Why is the index negative? Is this because the above line index = layerSize -1
There was a problem hiding this comment.
Thanks for checking it, indeed, it is adding at index 0 a layer but there are no layers present in the style yet, causing a -1 index
ignaciotcrespo
had a problem deploying
to
CI with Mapbox Tokens
GitHub Actions
Error
ignaciotcrespo
had a problem deploying
to
CI with Mapbox Tokens
GitHub Actions
Error
ignaciotcrespo
had a problem deploying
to
CI with Mapbox Tokens
GitHub Actions
Error
ignaciotcrespo
had a problem deploying
to
CI with Mapbox Tokens
GitHub Actions
Error
ignaciotcrespo
had a problem deploying
to
CI with Mapbox Tokens
GitHub Actions
Error
ignaciotcrespo
had a problem deploying
to
CI with Mapbox Tokens
GitHub Actions
Error
ignaciotcrespo
requested a deployment
to
CI with Mapbox Tokens
GitHub Actions
Waiting
ignaciotcrespo
requested a deployment
to
CI with Mapbox Tokens
GitHub Actions
Waiting
ignaciotcrespo
requested a deployment
to
CI with Mapbox Tokens
GitHub Actions
Waiting
ignaciotcrespo
requested a deployment
to
CI with Mapbox Tokens
GitHub Actions
Waiting
ignaciotcrespo
requested a deployment
to
CI with Mapbox Tokens
GitHub Actions
Waiting
ignaciotcrespo
requested a deployment
to
CI with Mapbox Tokens
GitHub Actions
Waiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using 3D themes in mapbox causes a crash in android devices. The layer index is not calculated correctly and can not be added.
The fix is to add a new layer when the calculated index is negative.
Checklist
CONTRIBUTING.mdyarn generatein the root folder/exampleapp./example)Screenshot OR Video
Component to reprocuce the issue you're fixing