added support for packages loadTranslationsFrom method #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sanlationsFrom with override ability from local language vendor folder
|
|
||
| $fullPath = $file->getRealPath(); | ||
| if ($extension == 'php') { | ||
| $messages[$key] = array_replace(Arr::get($messages,$key,[]), include $fullPath); |
There was a problem hiding this comment.
I think you need to check the include $fullPath actually returns a filled array before adding it.
You can add a test for it for trying to include a translation file, that isn't a valid translation file.
| { | ||
| $pathName = $file->getRelativePathName(); | ||
| $extension = $file->getExtension(); | ||
| if ($extension != 'php' && $extension != 'json') { |
There was a problem hiding this comment.
I'd change it to for readability
$supportedExtensions = ['json', 'php'];
!in_array($extension, $supportedExtensions)
I'm thinking laravel actually does this already somehow, maybe we should look into
The Illuminate\Translation\Translator uses Illuminate\Translation\FileLoaderto load/process files. Maybe we can use some of that logic
|
Seems like this ain't appyling to 1.7.0 for laravel 8 anymore |
added 2 commits
August 18, 2021 14:46
…lization into packages-loadTranslationsFrom-support
…ationsFrom-support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added support for packages which register language files via loadTranslationsFrom with override ability from local language vendor folder