Add support for spi-mode in cmdline #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks! Looks like the tests are failing due to #274. Once that's merged I'll take a look at this. |
thijstriemstra
requested changes
Jan 21, 2024
There was a problem hiding this comment.
Tests also ned to be adjusted since they're failing: https://github.com/rm-hull/luma.core/actions/runs/7603076282/job/20704367265?pr=273
AlessioMorale
force-pushed
the
amorale/272-support-spi-mode
branch
from
f42e149
to
e648528
Compare
AlessioMorale
force-pushed
the
amorale/272-support-spi-mode
branch
from
e648528
to
4ecc2c8
Compare
|
thanks! Tests should now be fine |
thijstriemstra
changed the title
thijstriemstra
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds support for '--spi-mode' command line option, fixes #272