update .readthedocs.yml to v2 #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rm-hull
previously approved these changes
Sep 1, 2023
rm-hull
previously approved these changes
Sep 1, 2023
|
Looks like the doc build is failing on Python 3.7 because it's using an old version of Sphinx (because python 3.7 support was dropped in sphinx v6.0 so no way to upgrade it either. The actual string it's failing on is not coming from luma.core but the intersphinx for Pillow, which likely was fixed in Sphinx at some point. Solution is skipping doc build on Python 3.7 (which we should drop support for sometime next year IMO). |
rm-hull
reviewed
Sep 1, 2023
| @@ -39,6 +40,7 @@ jobs: | |||
| python_env=$(echo $TOX_ENV | sed -e s/-dev$//) | |||
| python -m tox -e ${python_env} | |||
| - name: QA | |||
| if: ${{ steps.setuppy.outputs.python-version > 7 }} | |||
rm-hull
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.