rz_core_task_join: Return fine-grained error values #4505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazarmy
requested review from
wargio,
XVilka,
thestr4ng3r and
ret2libc
as code owners
XVilka
approved these changes
May 20, 2024
wargio
reviewed
May 21, 2024
librz/include/rz_core.h
Outdated
Comment on lines
1146
to
1147
| RZ_CORE_TASK_JOIN_ERR_NO_SEM_GROUP | ||
| } RzCoreTaskJoinErr; |
There was a problem hiding this comment.
maybe add a command to debug this?
There was a problem hiding this comment.
i mean, it gets returned but it is not used anywhere. maybe is worth logging it via RZ_LOG_DEBUG or similar.
There was a problem hiding this comment.
i agree that logging this can be useful ... currently, this is a symptom and not the cause though
XVilka
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
This pr makes
rz_core_task_join()return fine-grained error values.Test plan
All builds except the woodpecker build are green.
Closing issues
...