-
-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core/cmd: port /R
commands to the rzshell
#4504
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the issue related to this? Why under i
(which is usually for binary-related info)? I think there's something like this already under /R
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, they should be in the /R
commands, just put them into:
librz/core/cmd_descs/cmd_search.yaml
librz/core/cmd/cmd_search_rop.c
(this one should be updated from the old handlers to use the new handlers.
Moreover, I also recommend adding TABLE output, with more information about each gadget
Still WIP:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, much better now!
Some notes:
Please lmk if any other fields needed to be added which would be helpful in table mode. @XVilka |
Should be enough for now. Further improvements could be done when necessary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, please address my feedback first though
This comment was marked as resolved.
This comment was marked as resolved.
/R
commands to the rzshell
SQUASH ME
Your checklist for this pull request
Detailed description
Test plan
...
Closing issues
...