uplifting h8300 instructions to RzIL #4375
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashis Kumar Naik <[email protected]>
wargio
approved these changes
Mar 22, 2024
wargio
reviewed
Mar 22, 2024
wargio
reviewed
Mar 22, 2024
Signed-off-by: Ashis Kumar Naik <[email protected]>
XVilka
requested changes
Mar 22, 2024
There was a problem hiding this comment.
- Requires a test for RzIL, see how it's done, in
test/db/asm/h8300 - Windows linking error (you need to update Meson files
Creating library binrz/rz-run/rz-run.lib and object binrz/rz-run/rz-run.exp
rz_arch.lib(p_arch_h8300.c.obj) : error LNK2001: unresolved external symbol rz_h8300_il_config
rz_arch.lib(p_arch_h8300.c.obj) : error LNK2019: unresolved external symbol rz_h8300_il_opcode referenced in function h8300_op
binrz/rz-run/rz-run.exe : fatal error LNK1120: 2 unresolved externals
[1685/1953] Compiling C object binrz/rz-asm/rz-asm.exe.p/rz-asm.c.obj
ninja: build stopped: subcommand failed.
Command exited with code 1
XVilka
requested changes
Mar 22, 2024
librz/arch/isa/h8300/h8300_il.c
Outdated
| @@ -0,0 +1,491 @@ | |||
| // | |||
| // Created by Ashis Kumar Naik on 21/03/24. | |||
librz/arch/isa/h8300/h8300_il.h
Outdated
| @@ -0,0 +1,14 @@ | |||
| // | |||
| // Created by Ashis Kumar Naik on 21/03/24. | |||
Signed-off-by: Ashis Kumar Naik <[email protected]>
Rot127
reviewed
Mar 24, 2024
| @@ -12,6 +12,8 @@ | |||
|
|
|||
| #include <h8300/h8300_disas.h> | |||
|
|
|||
| #include "isa/h8300/h8300_il.h" | |||
There was a problem hiding this comment.
Suggested change
| #include "isa/h8300/h8300_il.h" | |
| #include <h8300/h8300_il.h> |
wargio
reviewed
Mar 25, 2024
| @@ -231,6 +231,7 @@ arch_isa_sources = [ | |||
| 'isa/sh/disassembler.c', | |||
| 'isa/sh/lookup.c', | |||
| 'isa/sh/sh_il.c', | |||
| 'isa/h8300/h8300_il.c', | |||
|
Don't forget to rebase when you do your next change. |
|
@ashiskumarnaik have you had any chance to fix this PR? |
|
@XVilka Hi , I am still working on it. |
|
Any updates? |
XVilka
requested changes
May 25, 2024
There was a problem hiding this comment.
It would require a "h8300" file with RzIL tests in this directoy as well: https://github.com/rizinorg/rizin/tree/dev/test/db/rzil
Including the "emulateme" type of test, where RzIL is used to emulate the part of the binary (see already existing tests in this directory).
For the instruction-level tests you will need to extend the https://github.com/rizinorg/rizin/blob/dev/test/db/asm/h8300 file with RzIL strings (see other files in that directory as an example)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
RzIL upliftment for H8300
...
...
for #2080
...