Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pvector for RzAnalysis/RzAnalysisBlock fcns variable. #4372

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Use pvector for RzAnalysis/RzAnalysisBlock fcns variable. #4372

wants to merge 1 commit into from

Conversation

wargio
Copy link
Member

@wargio wargio commented Mar 21, 2024 •
edited

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the rizin book with the relevant information (if needed)

Detailed description

rz_core_analysis_fcn_clean has been removed since it was wrong and unused.

@wargio
Use pvector for RzAnalysis/RzAnalysisBlock fcns variable.
afc78d9 
rz_core_analysis_fcn_clean has been removed.
XVilka
XVilka requested changes Apr 19, 2024
View reviewed changes
Copy link
Member

@XVilka XVilka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XVilka XVilka XVilka requested changes

@ret2libc ret2libc Awaiting requested review from ret2libc ret2libc is a code owner

@thestr4ng3r thestr4ng3r Awaiting requested review from thestr4ng3r thestr4ng3r is a code owner

@kazarmy kazarmy Awaiting requested review from kazarmy kazarmy is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
API ESIL panel rz-diff rz-test RzAnalysis RzCore RZIL RzUtil visual
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wargio @XVilka