Refactor to use API in Visual Mode #4339

HN026 · 2024-03-06T14:04:50Z

Your checklist for this pull request

I've read the guidelines for contributing to this repository
I made sure to follow the project's coding style
I've documented or updated the documentation of every function and struct this PR changes. If not so I've explained why.
I've added tests that prove my fix is effective or that my feature works (if possible)
I've updated the rizin book with the relevant information (if needed)

Detailed description

...

Test plan

...

Closing issues

Partially Addresses #382

...

librz/core/tui/visual.c

…lock_API

HN026 · 2024-03-11T15:02:21Z

I've somewhat implemented switching to a basic block after I list the basic blocks in the function. I feel it's far from complete. I would really like more insights on this. @XVilka

XVilka · 2024-03-11T15:34:48Z

I've somewhat implemented switching to a basic block after I list the basic blocks in the function. I feel it's far from complete. I would really like more insights on this. @XVilka

I think extracting and implementing ~... mode as an API would make more sense. Just like we extracted histogram creation with different options and data, the same could be done for the "search to navigate" "widget". Then you will be able to convert all of the s $(<command>~...) invocations ease.

HN026 · 2024-03-11T17:14:31Z

I've somewhat implemented switching to a basic block after I list the basic blocks in the function. I feel it's far from complete. I would really like more insights on this. @XVilka

I think extracting and implementing ~... mode as an API would make more sense. Just like we extracted histogram creation with different options and data, the same could be done for the "search to navigate" "widget". Then you will be able to convert all of the s $(<command>~...) invocations ease.

sure I will look into it, thanks

librz/core/core.c

…lock_API

librz/core/core.c

librz/core/tui/visual.c

…lock_API

librz/core/core.c

librz/core/tui/visual.c

…lock_API

librz/core/tui/visual.c

…PI' into rz_core_seek_first_basic_block_API

HN026 · 2024-03-24T17:15:38Z

I'm not somehow able to get the output for afb~... but it works fine in the visual mode, can you help ? @XVilka

XVilka

../librz/core/canalysis.c:455: error: identifier expected

librz/core/canalysis.c

librz/core/core.c

librz/core/tui/visual.c

librz/core/canalysis.c

librz/core/tui/visual.c

…lock_API

XVilka

Much better. Maybe you could also convert vbT to use (almost) the same logic. It should help you to make those functions more general.

librz/util/str.c

HN026 · 2024-03-26T15:06:06Z

Much better. Maybe you could also convert vbT to use (almost) the same logic. It should help you to make those functions more general.

Should I do that in this PR only ?

XVilka · 2024-03-26T23:46:15Z

Much better. Maybe you could also convert vbT to use (almost) the same logic. It should help you to make those functions more general.

Should I do that in this PR only ?

I think it would be nice to do that in the same PR, yes.

…lock_API

XVilka · 2024-04-19T11:41:52Z

librz/core/canalysis.c

@@ -446,33 +451,40 @@ static void bb_info_print(RzCore *core, RzAnalysisFunction *fcn, RzAnalysisBlock
 pj_ki(pj, "ninstr", bb->ninstr);
 pj_kb(pj, "traced", bb->traced);
 pj_end(pj);
+ char *json_str = rz_str_dup(pj_string(pj));
+ pj_free(pj);
+ rz_strbuf_append(buf, json_str);
 break;
 }
 case RZ_OUTPUT_MODE_TABLE:


It broke tables output:

[XX] db/cmd/tables tables sum RZ_NOPLUGINS=1 /Users/runner/bin/rizin -escr.utf8=0 -escr.color=0 -escr.interactive=0 -eflirt.sigdb.load.system=false -eflirt.sigdb.load.home=false -N -Qc 's main af afbt afbt:fancy afbt:size/sort/inc:simple ' bins/elf/hello_world -- stdout --- expected +++ actual @@ -1,17 +1,29 @@ -addr size jump fail ------------------------ -0x7aa 92 0x844 0x806 -0x806 62 0x844 -1 -0x844 3 -1 -1 -.------------------------------. -| addr | size | jump | fail | -)------------------------------( -| 0x7aa | 92 | 0x844 | 0x806 | -| 0x806 | 62 | 0x844 | -1 | -| 0x844 | 3 | -1 | -1 | -`------------------------------' -addr size jump fail ------------------------ -0x844 3 -1 -1 -0x806 62 0x844 -1 -0x7aa 92 0x844 0x806 +addr size jump fail +-------------------- +addr size jump fail +-------------------- +addr size jump fail +-------------------- + +addr size jump fail +-------------------- +addr size jump fail +-------------------- +addr size jump fail +-------------------- +addr size jump fail +-------------------- + +.---------------------------. +| addr | size | jump | fail | +)---------------------------( +`---------------------------' +addr size jump fail +-------------------- +addr size jump fail +-------------------- +addr size jump fail +-------------------- + +addr size jump fail +--------------------

Sure I will take a look on weekend and fix it, I had tried to fix it multiple times but it didn't help. On Weekend, I will try again.

XVilka · 2024-05-26T12:49:23Z

Could you please finish this one?

HN026 · 2024-06-07T10:19:24Z

Could you please finish this one?

Sure thing, Will do it once my exams are done.

Refactor to use API in Visual Mode

f124717

HN026 requested review from wargio, XVilka, kazarmy, thestr4ng3r and ret2libc as code owners March 6, 2024 14:04

github-actions bot added API RzCore labels Mar 6, 2024

XVilka requested changes Mar 6, 2024

View reviewed changes

librz/core/tui/visual.c Outdated Show resolved Hide resolved

HN026 added 2 commits March 11, 2024 13:40

Merge remote-tracking branch 'origin' into rz_core_seek_first_basic_b…

b31cdef

…lock_API

Seek to a basic Block

218d35a

github-actions bot added visual panel labels Mar 11, 2024

wargio reviewed Mar 12, 2024

View reviewed changes

librz/core/core.c Outdated Show resolved Hide resolved

HN026 added 2 commits March 14, 2024 11:33

Merge remote-tracking branch 'origin' into rz_core_seek_first_basic_b…

e4b73d5

…lock_API

Implemented an API for ~...

8f4ca29

wargio reviewed Mar 16, 2024

View reviewed changes

librz/core/core.c Outdated Show resolved Hide resolved

wargio reviewed Mar 16, 2024

View reviewed changes

librz/core/core.c Outdated Show resolved Hide resolved

XVilka requested changes Mar 16, 2024

View reviewed changes

librz/core/core.c Outdated Show resolved Hide resolved

librz/core/core.c Outdated Show resolved Hide resolved

librz/core/core.c Outdated Show resolved Hide resolved

librz/core/tui/visual.c Outdated Show resolved Hide resolved

HN026 added 2 commits March 16, 2024 21:33

Merge remote-tracking branch 'origin' into rz_core_seek_first_basic_b…

451c7b4

…lock_API

Changes and shifted to Visual.c

f180342

XVilka requested changes Mar 17, 2024

View reviewed changes

librz/core/core.c Outdated Show resolved Hide resolved

librz/core/core.c Outdated Show resolved Hide resolved

librz/core/core.c Outdated Show resolved Hide resolved

librz/core/tui/visual.c Outdated Show resolved Hide resolved

librz/core/tui/visual.c Outdated Show resolved Hide resolved

HN026 added 2 commits March 17, 2024 17:57

Merge remote-tracking branch 'origin' into rz_core_seek_first_basic_b…

6bd97f4

…lock_API

Afb function

aa4d719

XVilka requested changes Mar 18, 2024

View reviewed changes

librz/core/tui/visual.c Outdated Show resolved Hide resolved

librz/core/tui/visual.c Outdated Show resolved Hide resolved

HN026 added 2 commits March 24, 2024 22:34

Refactor to use API in Visual Mode

c060829

Seek to a basic Block

8df818c

HN026 and others added 6 commits March 24, 2024 22:34

Implemented an API for ~...

da5f4f9

Changes and shifted to Visual.c

bd6421f

Afb function

42fadc8

Merge branch 'rizinorg:dev' into dev

75f6fff

refactor

737deda

Merge remote-tracking branch 'origin/rz_core_seek_first_basic_block_A…

b809714

…PI' into rz_core_seek_first_basic_block_API

HN026 and others added 2 commits March 24, 2024 22:51

free to RZ_FREE

ce4beb8

Update visual.c

5042768

HN026 requested a review from XVilka March 25, 2024 12:30

XVilka requested changes Mar 25, 2024

View reviewed changes

wargio reviewed Mar 25, 2024

View reviewed changes

librz/core/tui/visual.c Outdated Show resolved Hide resolved

HN026 added 3 commits March 26, 2024 17:53

Merge remote-tracking branch 'origin' into rz_core_seek_first_basic_b…

cedcabb

…lock_API

Merge remote-tracking branch 'origin' into rz_core_seek_first_basic_b…

65e737e

…lock_API

refactor and function namechanges

1ae6f5d

github-actions bot added the RzUtil label Mar 26, 2024

NULL check

0ba5529

HN026 requested a review from XVilka March 26, 2024 14:47

XVilka requested changes Mar 26, 2024

View reviewed changes

librz/util/str.c Outdated Show resolved Hide resolved

HN026 added 2 commits March 31, 2024 11:42

Merge remote-tracking branch 'origin' into rz_core_seek_first_basic_b…

06bc8c9

…lock_API

vbt to direct API

03204e8

HN026 requested a review from XVilka March 31, 2024 09:50

JSON mode changes

a2ef3ea

HN026 requested a review from wargio March 31, 2024 14:20

XVilka requested changes Apr 19, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor to use API in Visual Mode #4339

Refactor to use API in Visual Mode #4339

HN026 commented Mar 6, 2024 •

edited

HN026 commented Mar 11, 2024

XVilka commented Mar 11, 2024

HN026 commented Mar 11, 2024

HN026 commented Mar 24, 2024

XVilka left a comment

XVilka left a comment

HN026 commented Mar 26, 2024

XVilka commented Mar 26, 2024

XVilka Apr 19, 2024

HN026 Apr 19, 2024

XVilka commented May 26, 2024

HN026 commented Jun 7, 2024

Refactor to use API in Visual Mode #4339

Are you sure you want to change the base?

Refactor to use API in Visual Mode #4339

Conversation

HN026 commented Mar 6, 2024 • edited

HN026 commented Mar 11, 2024

XVilka commented Mar 11, 2024

HN026 commented Mar 11, 2024

HN026 commented Mar 24, 2024

XVilka left a comment

Choose a reason for hiding this comment

XVilka left a comment

Choose a reason for hiding this comment

HN026 commented Mar 26, 2024

XVilka commented Mar 26, 2024

XVilka Apr 19, 2024

Choose a reason for hiding this comment

HN026 Apr 19, 2024

Choose a reason for hiding this comment

XVilka commented May 26, 2024

HN026 commented Jun 7, 2024

HN026 commented Mar 6, 2024 •

edited