Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a restart button to the pause menu #126

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

cbruegg
Copy link

@cbruegg cbruegg commented Jun 3, 2021

I find myself restarting / resetting the emulation quite often to go back to my last save (i.e. an actual in-game save, not through Delta's save state feature). Currently this requires going back to the main menu, tapping on the same ROM and finally pressing the Restart button to confirm.

This PR adds a restart button to the pause menu. As it's a rather destructive action, pressing it will still show an alert asking the user to confirm, but this still streamlines the process.

I'm very inexperienced with Swift, so if there's anything in need of improvement here, let me know and I'll be happy to fix it.

The replay button icon has been taken from Material Icons. It's Apache 2-licensed, which should be compatible with AGPL.

@cbruegg
Copy link
Author

cbruegg commented Jun 18, 2021

Sorry to bother, did you have a chance to look at this yet? Thanks!

@lonkelle
Copy link
Collaborator

Hey @cbruegg. I'm looking through this PR now. This isn't a bad idea at all, it's made me think of making the in-game Delta menu customizable and adding your button to the list.

Do you have any other ideas for buttons we could add to the in-game menu list aside from your added "Reset" button?

@lonkelle
Copy link
Collaborator

Would you mind adding a screenshot of your new button on here?

Your pull request inspired me to write this card btw: https://trello.com/c/JgDxONsL/207-setting-customizable-in-game-menu-button-order-and-remove-add

PS. I also added you to our Trello board here: https://trello.com/c/wQmkrxgB/202-enhancement-add-a-reset-button-to-the-in-game-menu-pr-christian-brüggemann - you should join us on our Discord: https://bit.ly/altmember-delta-general-chat

@cbruegg
Copy link
Author

cbruegg commented Jul 4, 2021

Hi @lonkle, sorry for the delay - my past week has been really busy. Here's what the feature looks like:

Other buttons I think could be useful:

  • Quick Save: Creates a new save state without having to open the save state menu
  • Quick Load: Loads the most recent save state. There'd need to be a way for the user to undo this when pressed accidentally. I haven't quite figured out how that could be made to work smoothly.
  • Toggle all cheats on/off
  • Fast Forward without emulation speed limit (or at least 2x of the usual limit)

Making the menu customisable sounds like a great idea. Ideally it would also be possible to assign gamepad shortcuts to the menu items.

@lonkelle
Copy link
Collaborator

lonkelle commented Jul 6, 2021

Those were great suggestions, I've added them to our roadmap:

https://trello.com/c/BTvdcooT/237-enhancement-be-able-to-map-gamepad-buttons-to-in-game-menu-items
https://trello.com/c/BA0GmZ6M/238-enhancement-give-the-user-the-ability-to-undo-an-accidental-quick-save-or-quick-load

Tell me what you think about my solution for "undo-ing" quick saves and quick loads. Likewise, you're also featured on the Trello roadmap if you look at the "Ready to be Merged" list (this PR is on there).

Lastly, what does "Fast Forward without emulation speed limit" mean? Isn't that what fast forward is, removing the speed limit? Or are you saying you just want variable speeds?

@cbruegg
Copy link
Author

cbruegg commented Jul 6, 2021

I think the temporary 'undo' buttons sound like a good solution :)

Likewise, you're also featured on the Trello roadmap if you look at the "Ready to be Merged" list (this PR is on there).

That's cool, thanks!

Lastly, what does "Fast Forward without emulation speed limit" mean? Isn't that what fast forward is, removing the speed limit? Or are you saying you just want variable speeds?

As far as I'm aware, Delta currently has a hard cap for the fast forward speed, probably to avoid making it unplayably fast. Sometimes though I'd like to really go as fast as the CPU allows, e.g. to hatch eggs in Pokémon games.

@lonkelle
Copy link
Collaborator

lonkelle commented Jul 6, 2021

Good suggestion, I added your unlimited speed option to this pre-existing Trello card: https://trello.com/c/100N36tE/14-setting-variable-fast-forward-speeds

Feel free to join our Discord if you ever wanna talk Delta! https://bit.ly/altmember-delta-general-chat

@mercpls
Copy link

mercpls commented May 11, 2024

Is there anything preventing this from being merged? Seems like a useful feature

@cbruegg
Copy link
Author

cbruegg commented May 12, 2024

I've resolved the merge conflict, so hopefully? :) @lonkelle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants