Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace busboy with @fastify/busboy #361

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rtritto
Copy link

@rtritto rtritto commented Oct 22, 2023

@fastify/busboy is a better version of busboy for performance, maintenance and some solved critical bug.

Related: fastify/busboy#68

@coveralls
Copy link

Coverage Status

coverage: 94.785%. remained the same when pulling 5d07c5c on rtritto:replace-fastify into fcb6952 on richardgirges:master.

@rtritto
Copy link
Author

rtritto commented Oct 22, 2023

@fastify/busboy forked branch isn't currently alligned with busboy branch: fastify/busboy#78.
I think we should wait to merge this.

@rtritto
Copy link
Author

rtritto commented Jun 5, 2024

@RomanBurunkov @RobinTail any update to merge this PR?

@RobinTail
Copy link
Contributor

RobinTail commented Jun 5, 2024

It may appear that may, but I'm not the one who decides for this repo, @rtritto :)

You also said

I think we should wait to merge this.

So, should we? Please let the maintainer know.

@rtritto
Copy link
Author

rtritto commented Jun 5, 2024

It's active and maintained by team of undici

@RobinTail
Copy link
Contributor

@RomanBurunkov || @richardgirges , please take a look on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants