Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version #16

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

New version #16

wants to merge 6 commits into from

Conversation

Scolymus
Copy link

Hi,

I tried your module and when I checked the code I decided to update it becaue for example, you had 2 judges and one is down, so your module is not working right anymore because you choose randomly the judges to check proxies. Therefore, 50% of the times it will fail due to an error of a judge, not because the proxy is down... but it will say the proxy is down.

Here you have the changes:

  1. I extended the judges to the list of the other PR you have, although there was 1 down so I removed it. To prevent this problem in the future, I check every time the object is created if the judges are running. If not I remove them from the list.
  2. I decided to add the option to change the timeout. Timeout can be added in the object creation or afterwards. Also, now timeout is in ms, not in seconds.
  3. I let the option to print the verbose from pycurl, same as with timeout.
  4. I check if myip is not empty after you create the object. Imagine you create the object and the website for IP is down... that's a nonsense to continue, no?
  5. I added an option for https and allowed to change the TLS version used. I'm not sure if this implementation is correct though...
  6. When checking the proxy now you can select the specific protocol to check, or a list of protocols if you want. (Not specifying means to check all). Also, if you found one, you have the option to do not check other types of protocols. Moreover, checks can fail. So if at the end of checking all protocols there's no one working, you have the option to retry the check n times. If at some retry there's one working, it won't retry it again.
  7. Methods are commented, and types of variables are detailed.

I'm worried about the checking of anonimity. I saw how taking the same proxy but running several times, sometimes I had transparent while others elite.... I do not know why...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant