Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Disable the "reported by reviewdog 馃惗" Prefix in Review Messages #1667

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

feat: Disable the "reported by reviewdog 馃惗" Prefix in Review Messages #1667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5df27f0
del: msg: reported by reviewdog
Okabe-Junya Feb 9, 2024
24be1d6
update: README
Okabe-Junya Feb 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,7 +498,7 @@ github-pr-annotations uses the GitHub Actions annotation format to output errors
and warnings to `stdout` e.g.

```
::error line=11,col=41,file=app/index.md::[vale] reported by reviewdog 馃惗%0A[demo.Spelling] Did you really mean 'boobarbaz'?%0A%0ARaw Output:%0A{"message": "[demo.Spelling] Did you really mean 'boobarbaz'?", "location": {"path": "app/index.md", "range": {"start": {"line": 11, "column": 41}}}, "severity": "ERROR"}
::error line=11,col=41,file=app/index.md::[vale]%0A[demo.Spelling] Did you really mean 'boobarbaz'?%0A%0ARaw Output:%0A{"message": "[demo.Spelling] Did you really mean 'boobarbaz'?", "location": {"path": "app/index.md", "range": {"start": {"line": 11, "column": 41}}}, "severity": "ERROR"}
```

This reporter requires a valid GitHub API token to generate a diff, but will not
Expand Down
2 changes: 1 addition & 1 deletion service/github/githubutils/comment_writer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ func (lw *GitHubActionLogWriter) Flush(_ context.Context) error {
// annotations.
// https://help.github.com/en/actions/automating-your-workflow-with-github-actions/development-tools-for-github-actions#example-5
func ReportAsGitHubActionsLog(toolName, defaultLevel string, d *rdf.Diagnostic) {
mes := fmt.Sprintf("[%s] reported by reviewdog 馃惗\n%s\n\nRaw Output:\n%s",
mes := fmt.Sprintf("[%s]\n%s\n\nRaw Output:\n%s",
toolName, d.GetMessage(), d.GetOriginalOutput())
loc := d.GetLocation()
start := loc.GetRange().GetStart()
Expand Down