Do not retry permanent backend failures #4803
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
Restic currently retries attempts to access a non-existing file or out of bound reads for truncated files. These errors are however permanent and cannot be fixed by retrying. This PR adds the necessary infrastructure to let the RetryBackend detect these cases and stop the useless retries.
In addition, the RetryBackend now implements a circuit breaker for inaccessible files. If accessing a file exhausts its retries, then the file is considered broken and won't be accessed again for one hour. This also benefits #4800 , as the fallback paths will immediately fail for such broken files.
Was the change previously discussed in an issue or on the forum?
Not really, but this is another prerequisite (and hopefully the last one) for #4784 .
Checklist
[ ] I have added documentation for relevant changes (in the manual).changelog/unreleased/
that describes the changes for our users (see template).gofmt
on the code in all commits.